Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2448943003: Fix some return FALSE in functions that return pointers (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix some return FALSE in functions that return pointers This previously compiled because FALSE is #defined to 0, and 0 is a perfectly fine value for a pointer. Committed: https://pdfium.googlesource.com/pdfium/+/04c1009af887eb5d3a183dd26421f644f63d8b77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_simple_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Tom Sepez
npm, quick review.
4 years, 1 month ago (2016-10-25 22:03:11 UTC) #4
npm
lgtm
4 years, 1 month ago (2016-10-25 22:07:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448943003/1
4 years, 1 month ago (2016-10-25 22:10:56 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 22:16:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/04c1009af887eb5d3a183dd26421f644f63d...

Powered by Google App Engine
This is Rietveld 408576698