Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: xfa/fxfa/parser/xfa_document_datamerger_imp.cpp

Issue 2448943003: Fix some return FALSE in functions that return pointers (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxfa/parser/cxfa_simple_parser.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/parser/xfa_document_datamerger_imp.h" 7 #include "xfa/fxfa/parser/xfa_document_datamerger_imp.h"
8 8
9 #include "core/fxcrt/fx_ext.h" 9 #include "core/fxcrt/fx_ext.h"
10 #include "xfa/fde/xml/fde_xml_imp.h" 10 #include "xfa/fde/xml/fde_xml_imp.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 return FALSE; 45 return FALSE;
46 46
47 CXFA_Occur occur(pOccurNode); 47 CXFA_Occur occur(pOccurNode);
48 return occur.GetOccurInfo(iMin, iMax, iInit); 48 return occur.GetOccurInfo(iMin, iMax, iInit);
49 } 49 }
50 50
51 CXFA_Node* FormValueNode_CreateChild(CXFA_Node* pValueNode, XFA_Element iType) { 51 CXFA_Node* FormValueNode_CreateChild(CXFA_Node* pValueNode, XFA_Element iType) {
52 CXFA_Node* pChildNode = pValueNode->GetNodeItem(XFA_NODEITEM_FirstChild); 52 CXFA_Node* pChildNode = pValueNode->GetNodeItem(XFA_NODEITEM_FirstChild);
53 if (!pChildNode) { 53 if (!pChildNode) {
54 if (iType == XFA_Element::Unknown) 54 if (iType == XFA_Element::Unknown)
55 return FALSE; 55 return nullptr;
56 pChildNode = pValueNode->GetProperty(0, iType); 56 pChildNode = pValueNode->GetProperty(0, iType);
57 } 57 }
58 return pChildNode; 58 return pChildNode;
59 } 59 }
60 60
61 void FormValueNode_MatchNoneCreateChild(CXFA_Node* pFormNode) { 61 void FormValueNode_MatchNoneCreateChild(CXFA_Node* pFormNode) {
62 CXFA_WidgetData* pWidgetData = pFormNode->GetWidgetData(); 62 CXFA_WidgetData* pWidgetData = pFormNode->GetWidgetData();
63 ASSERT(pWidgetData); 63 ASSERT(pWidgetData);
64 pWidgetData->GetUIType(); 64 pWidgetData->GetUIType();
65 } 65 }
(...skipping 1454 matching lines...) Expand 10 before | Expand all | Expand 10 after
1520 pFormRoot->RemoveChild(pNode); 1520 pFormRoot->RemoveChild(pNode);
1521 pFormRoot->SetObject(XFA_ATTRIBUTE_BindingNode, nullptr); 1521 pFormRoot->SetObject(XFA_ATTRIBUTE_BindingNode, nullptr);
1522 } 1522 }
1523 m_rgGlobalBinding.RemoveAll(); 1523 m_rgGlobalBinding.RemoveAll();
1524 if (bDoDataMerge) 1524 if (bDoDataMerge)
1525 DoDataMerge(); 1525 DoDataMerge();
1526 1526
1527 CXFA_LayoutProcessor* pLayoutProcessor = GetLayoutProcessor(); 1527 CXFA_LayoutProcessor* pLayoutProcessor = GetLayoutProcessor();
1528 pLayoutProcessor->SetForceReLayout(TRUE); 1528 pLayoutProcessor->SetForceReLayout(TRUE);
1529 } 1529 }
OLDNEW
« no previous file with comments | « xfa/fxfa/parser/cxfa_simple_parser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698