[compiler] Make SFI "optimize" flag a "tier up" flag

src/objects.h

Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index ef3f31df4793aefb3cdfbc7012a9c889589b8fb7..9761725820ebeedaf096b820ce9fd06016220748 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -7669,7 +7669,7 @@ class SharedFunctionInfo: public HeapObject {
   DECL_BOOLEAN_ACCESSORS(is_declaration)
 
   // Whether this function was marked to be optimized.
-  DECL_BOOLEAN_ACCESSORS(was_marked_for_optimization)
+  DECL_BOOLEAN_ACCESSORS(was_marked_for_tier_up)

[rmcilroy, 2016/10/26 15:07:59]

nit - marked_for_tier_up (drop the "was_")

[Leszek Swirski, 2016/10/27 09:40:20]

Done. I'm not sure about the "marked_for_" either, maybe it'd be simpler to just
call it tier_up? WDYT?

 
   // Indicates that asm->wasm conversion failed and should not be re-attempted.
   DECL_BOOLEAN_ACCESSORS(is_asm_wasm_broken)
@@ -7920,7 +7920,7 @@ class SharedFunctionInfo: public HeapObject {
   enum CompilerHints {
     // byte 0
     kAllowLazyCompilation,
-    kWasMarkedForOptimization,
+    kWasMarkedForTierUp,

[rmcilroy, 2016/10/26 15:07:59]

ditto and below

[Leszek Swirski, 2016/10/27 09:40:20]

Done.

     kOptimizationDisabled,
     kNeverCompiled,
     kNative,
@@ -7988,8 +7988,8 @@ class SharedFunctionInfo: public HeapObject {
   static const int kAllFunctionKindBitsMask = FunctionKindBits::kMask
                                               << kCompilerHintsSmiTagSize;
 
-  static const int kWasMarkedForOptimizationBit =
-      kWasMarkedForOptimization + kCompilerHintsSmiTagSize;
+  static const int kWasMarkedForTierUpBit =
+      kWasMarkedForTierUp + kCompilerHintsSmiTagSize;
 
   // Constants for optimizing codegen for strict mode function and
   // native tests.
@@ -8003,8 +8003,8 @@ class SharedFunctionInfo: public HeapObject {
       FunctionKind::kClassConstructor << kCompilerHintsSmiTagSize;
   STATIC_ASSERT(kClassConstructorBitsWithinByte < (1 << kBitsPerByte));
 
-  static const int kWasMarkedForOptimizationBitWithinByte =
-      kWasMarkedForOptimizationBit % kBitsPerByte;
+  static const int kWasMarkedForTierUpBitWithinByte =
+      kWasMarkedForTierUpBit % kBitsPerByte;
 
 #if defined(V8_TARGET_LITTLE_ENDIAN)
 #define BYTE_OFFSET(compiler_hint) \
@@ -8022,8 +8022,8 @@ class SharedFunctionInfo: public HeapObject {
   static const int kFunctionKindByteOffset = BYTE_OFFSET(kFunctionKind);
   static const int kHasDuplicateParametersByteOffset =
       BYTE_OFFSET(kHasDuplicateParameters);
-  static const int kWasMarkedForOptimizationByteOffset =
-      BYTE_OFFSET(kWasMarkedForOptimization);
+  static const int kWasMarkedForTierUpByteOffset =
+      BYTE_OFFSET(kWasMarkedForTierUp);
 #undef BYTE_OFFSET
 
  private: