[compiler] Make SFI "optimize" flag a "tier up" flag

src/objects.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 #include <memory>
 
@@ skipping 7651 matching lines @@
   // Indicates that the the shared function info is deserialized from cache.
   DECL_BOOLEAN_ACCESSORS(deserialized)
 
   // Indicates that the the shared function info has never been compiled before.
   DECL_BOOLEAN_ACCESSORS(never_compiled)
 
   // Whether this function was created from a FunctionDeclaration.
   DECL_BOOLEAN_ACCESSORS(is_declaration)
 
   // Whether this function was marked to be optimized.
-  DECL_BOOLEAN_ACCESSORS(was_marked_for_optimization)
+  DECL_BOOLEAN_ACCESSORS(was_marked_for_tier_up)

[rmcilroy, 2016/10/26 15:07:59]

nit - marked_for_tier_up (drop the "was_")

[Leszek Swirski, 2016/10/27 09:40:20]

Done. I'm not sure about the "marked_for_" either, maybe it'd be simpler to just
call it tier_up? WDYT?

 
   // Indicates that asm->wasm conversion failed and should not be re-attempted.
   DECL_BOOLEAN_ACCESSORS(is_asm_wasm_broken)
 
   inline FunctionKind kind() const;
   inline void set_kind(FunctionKind kind);
 
   // Indicates whether or not the code in the shared function support
   // deoptimization.
   inline bool has_deoptimization_support();
@@ skipping 230 matching lines @@
   // the start_position_and_type field.
   static const int kIsNamedExpressionBit = 0;
   static const int kIsTopLevelBit = 1;
   static const int kStartPositionShift = 2;
   static const int kStartPositionMask = ~((1 << kStartPositionShift) - 1);
 
   // Bit positions in compiler_hints.
   enum CompilerHints {
     // byte 0
     kAllowLazyCompilation,
-    kWasMarkedForOptimization,
+    kWasMarkedForTierUp,

[rmcilroy, 2016/10/26 15:07:59]

ditto and below

[Leszek Swirski, 2016/10/27 09:40:20]

Done.

     kOptimizationDisabled,
     kNeverCompiled,
     kNative,
     kStrictModeFunction,
     kUsesArguments,
     kNeedsHomeObject,
     // byte 1
     kHasDuplicateParameters,
     kForceInline,
     kIsAsmFunction,
@@ skipping 47 matching lines @@
       kStrictModeFunction + kCompilerHintsSmiTagSize;
   static const int kNativeBit = kNative + kCompilerHintsSmiTagSize;
   static const int kHasDuplicateParametersBit =
       kHasDuplicateParameters + kCompilerHintsSmiTagSize;
 
   static const int kFunctionKindShift =
       kFunctionKind + kCompilerHintsSmiTagSize;
   static const int kAllFunctionKindBitsMask = FunctionKindBits::kMask
                                               << kCompilerHintsSmiTagSize;
 
-  static const int kWasMarkedForOptimizationBit =
-      kWasMarkedForOptimization + kCompilerHintsSmiTagSize;
+  static const int kWasMarkedForTierUpBit =
+      kWasMarkedForTierUp + kCompilerHintsSmiTagSize;
 
   // Constants for optimizing codegen for strict mode function and
   // native tests.
   // Allows to use byte-width instructions.
   static const int kStrictModeBitWithinByte = kStrictModeBit % kBitsPerByte;
   static const int kNativeBitWithinByte = kNativeBit % kBitsPerByte;
   static const int kHasDuplicateParametersBitWithinByte =
       kHasDuplicateParametersBit % kBitsPerByte;
 
   static const int kClassConstructorBitsWithinByte =
       FunctionKind::kClassConstructor << kCompilerHintsSmiTagSize;
   STATIC_ASSERT(kClassConstructorBitsWithinByte < (1 << kBitsPerByte));
 
-  static const int kWasMarkedForOptimizationBitWithinByte =
-      kWasMarkedForOptimizationBit % kBitsPerByte;
+  static const int kWasMarkedForTierUpBitWithinByte =
+      kWasMarkedForTierUpBit % kBitsPerByte;
 
 #if defined(V8_TARGET_LITTLE_ENDIAN)
 #define BYTE_OFFSET(compiler_hint) \
   kCompilerHintsOffset +           \
       (compiler_hint + kCompilerHintsSmiTagSize) / kBitsPerByte
 #elif defined(V8_TARGET_BIG_ENDIAN)
 #define BYTE_OFFSET(compiler_hint)                  \
   kCompilerHintsOffset + (kCompilerHintsSize - 1) - \
       ((compiler_hint + kCompilerHintsSmiTagSize) / kBitsPerByte)
 #else
 #error Unknown byte ordering
 #endif
   static const int kStrictModeByteOffset = BYTE_OFFSET(kStrictModeFunction);
   static const int kNativeByteOffset = BYTE_OFFSET(kNative);
   static const int kFunctionKindByteOffset = BYTE_OFFSET(kFunctionKind);
   static const int kHasDuplicateParametersByteOffset =
       BYTE_OFFSET(kHasDuplicateParameters);
-  static const int kWasMarkedForOptimizationByteOffset =
-      BYTE_OFFSET(kWasMarkedForOptimization);
+  static const int kWasMarkedForTierUpByteOffset =
+      BYTE_OFFSET(kWasMarkedForTierUp);
 #undef BYTE_OFFSET
 
  private:
   // Returns entry from optimized code map for specified context and OSR entry.
   // The result is either kNotFound, or a start index of the context-dependent
   // entry.
   int SearchOptimizedCodeMapEntry(Context* native_context,
                                   BailoutId osr_ast_id);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(SharedFunctionInfo);
@@ skipping 3719 matching lines @@
     }
     return value;
   }
 };
 
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_