Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: src/builtins/arm/builtins-arm.cc

Issue 2448933002: [compiler] Make SFI "optimize" flag a "tier up" flag (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins/arm64/builtins-arm64.cc » ('j') | src/compiler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/arm/builtins-arm.cc
diff --git a/src/builtins/arm/builtins-arm.cc b/src/builtins/arm/builtins-arm.cc
index b739545996e3e206ce3eab1a24ccbb56cda843b9..31813e89694c56e9e7f5fd395d2606aef66d6c0a 100644
--- a/src/builtins/arm/builtins-arm.cc
+++ b/src/builtins/arm/builtins-arm.cc
@@ -1483,12 +1483,10 @@ void Builtins::Generate_CompileLazy(MacroAssembler* masm) {
__ ldr(entry,
FieldMemOperand(closure, JSFunction::kSharedFunctionInfoOffset));
// Is the shared function marked for optimization?
rmcilroy 2016/10/26 15:07:59 update comment (throughtout)
Leszek Swirski 2016/10/27 09:40:20 Done.
- __ ldrb(r5,
- FieldMemOperand(
- entry, SharedFunctionInfo::kWasMarkedForOptimizationByteOffset));
- __ tst(
- r5,
- Operand(1 << SharedFunctionInfo::kWasMarkedForOptimizationBitWithinByte));
+ __ ldrb(r5, FieldMemOperand(
+ entry, SharedFunctionInfo::kWasMarkedForTierUpByteOffset));
+ __ tst(r5,
+ Operand(1 << SharedFunctionInfo::kWasMarkedForTierUpBitWithinByte));
__ b(eq, &gotta_call_runtime_no_stack);
// Is the full code valid?
__ ldr(entry, FieldMemOperand(entry, SharedFunctionInfo::kCodeOffset));
« no previous file with comments | « no previous file | src/builtins/arm64/builtins-arm64.cc » ('j') | src/compiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698