Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/builtins/arm/builtins-arm.cc

Issue 2448933002: [compiler] Make SFI "optimize" flag a "tier up" flag (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins/arm64/builtins-arm64.cc » ('j') | src/compiler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 1464 matching lines...) Expand 10 before | Expand all | Expand 10 after
1475 1475
1476 // We found neither literals nor code. 1476 // We found neither literals nor code.
1477 __ jmp(&gotta_call_runtime); 1477 __ jmp(&gotta_call_runtime);
1478 1478
1479 __ bind(&try_shared); 1479 __ bind(&try_shared);
1480 __ pop(closure); 1480 __ pop(closure);
1481 __ pop(new_target); 1481 __ pop(new_target);
1482 __ pop(argument_count); 1482 __ pop(argument_count);
1483 __ ldr(entry, 1483 __ ldr(entry,
1484 FieldMemOperand(closure, JSFunction::kSharedFunctionInfoOffset)); 1484 FieldMemOperand(closure, JSFunction::kSharedFunctionInfoOffset));
1485 // Is the shared function marked for optimization? 1485 // Is the shared function marked for optimization?
rmcilroy 2016/10/26 15:07:59 update comment (throughtout)
Leszek Swirski 2016/10/27 09:40:20 Done.
1486 __ ldrb(r5, 1486 __ ldrb(r5, FieldMemOperand(
1487 FieldMemOperand( 1487 entry, SharedFunctionInfo::kWasMarkedForTierUpByteOffset));
1488 entry, SharedFunctionInfo::kWasMarkedForOptimizationByteOffset)); 1488 __ tst(r5,
1489 __ tst( 1489 Operand(1 << SharedFunctionInfo::kWasMarkedForTierUpBitWithinByte));
1490 r5,
1491 Operand(1 << SharedFunctionInfo::kWasMarkedForOptimizationBitWithinByte));
1492 __ b(eq, &gotta_call_runtime_no_stack); 1490 __ b(eq, &gotta_call_runtime_no_stack);
1493 // Is the full code valid? 1491 // Is the full code valid?
1494 __ ldr(entry, FieldMemOperand(entry, SharedFunctionInfo::kCodeOffset)); 1492 __ ldr(entry, FieldMemOperand(entry, SharedFunctionInfo::kCodeOffset));
1495 __ ldr(r5, FieldMemOperand(entry, Code::kFlagsOffset)); 1493 __ ldr(r5, FieldMemOperand(entry, Code::kFlagsOffset));
1496 __ and_(r5, r5, Operand(Code::KindField::kMask)); 1494 __ and_(r5, r5, Operand(Code::KindField::kMask));
1497 __ mov(r5, Operand(r5, LSR, Code::KindField::kShift)); 1495 __ mov(r5, Operand(r5, LSR, Code::KindField::kShift));
1498 __ cmp(r5, Operand(Code::BUILTIN)); 1496 __ cmp(r5, Operand(Code::BUILTIN));
1499 __ b(eq, &gotta_call_runtime_no_stack); 1497 __ b(eq, &gotta_call_runtime_no_stack);
1500 // Yes, install the full code. 1498 // Yes, install the full code.
1501 __ add(entry, entry, Operand(Code::kHeaderSize - kHeapObjectTag)); 1499 __ add(entry, entry, Operand(Code::kHeaderSize - kHeapObjectTag));
(...skipping 1413 matching lines...) Expand 10 before | Expand all | Expand 10 after
2915 __ bkpt(0); 2913 __ bkpt(0);
2916 } 2914 }
2917 } 2915 }
2918 2916
2919 #undef __ 2917 #undef __
2920 2918
2921 } // namespace internal 2919 } // namespace internal
2922 } // namespace v8 2920 } // namespace v8
2923 2921
2924 #endif // V8_TARGET_ARCH_ARM 2922 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/builtins/arm64/builtins-arm64.cc » ('j') | src/compiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698