Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2448873003:
V8: Use new slave-preference function on tryserver (Closed)
|
Created:
4 years, 1 month ago by Michael Achenbach Modified:
4 years, 1 month ago Reviewers:
tandrii(chromium) CC:
chromium-reviews, infra-reviews+build_chromium.org Target Ref:
refs/heads/master Project:
build Visibility:
Public. |
DescriptionV8: Use new slave-preference function on tryserver
BUG=658189
Committed: https://chromium.googlesource.com/chromium/tools/build/+/1978a7f881b4583c3f87362961dbe82cc20ccf52
Committed: https://chromium.googlesource.com/chromium/tools/build/+/f836c59cebc8bc5a41b8c6c128e293c2592104a2
Patch Set 1 #
Messages
Total messages: 16 (7 generated)
Description was changed from ========== V8: Use new slave-preference function on tryserver BUG= ========== to ========== V8: Use new slave-preference function on tryserver BUG=658189 ==========
machenbach@chromium.org changed reviewers: + tandrii@chromium.org
PTAL
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== V8: Use new slave-preference function on tryserver BUG=658189 ========== to ========== V8: Use new slave-preference function on tryserver BUG=658189 Committed: https://chromium.googlesource.com/chromium/tools/build/+/1978a7f881b4583c3f87... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/1978a7f881b4583c3f87...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2448033003/ by machenbach@chromium.org. The reason for reverting is: Fails on master.
Message was sent while issue was closed.
On 2016/10/25 13:50:19, machenbach (slow) wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2448033003/ by mailto:machenbach@chromium.org. > > The reason for reverting is: Fails on master. 2016-10-25 06:46:47-0700 [-] in maybeStartBuild for <Builder ''v8_linux64_rel_ng'' at 71304040> Traceback (most recent call last): File "/home/chrome-bot/buildbot/build/third_party/twisted_10_2/twisted/internet/defer.py", line 891, in gotResult _deferGenerator(g, deferred) File "/home/chrome-bot/buildbot/build/third_party/twisted_10_2/twisted/internet/defer.py", line 866, in _deferGenerator result = g.next() File "/home/chrome-bot/buildbot/build/third_party/buildbot_8_4p1/buildbot/process/builder.py", line 708, in maybeStartBuild self._chooseSlave(available_slavebuilders)) File "/home/chrome-bot/buildbot/build/third_party/buildbot_8_4p1/buildbot/process/builder.py", line 790, in _chooseSlave return defer.maybeDeferred(lambda : --- <exception caught here> --- File "/home/chrome-bot/buildbot/build/third_party/twisted_10_2/twisted/internet/defer.py", line 133, in maybeDeferred result = f(*args, **kw) File "/home/chrome-bot/buildbot/build/third_party/buildbot_8_4p1/buildbot/process/builder.py", line 791, in <lambda> self.nextSlave(self, available_slavebuilders)) File "/home/chrome-bot/buildbot/build/scripts/master/master_utils.py", line 708, in __call__ s for s in slave_builders File "/usr/lib/python2.7/random.py", line 274, in choice return seq[int(self.random() * len(seq))] # raises IndexError if seq is empty exceptions.TypeError: object of type 'generator' has no len()
Message was sent while issue was closed.
Description was changed from ========== V8: Use new slave-preference function on tryserver BUG=658189 Committed: https://chromium.googlesource.com/chromium/tools/build/+/1978a7f881b4583c3f87... ========== to ========== V8: Use new slave-preference function on tryserver BUG=658189 Committed: https://chromium.googlesource.com/chromium/tools/build/+/1978a7f881b4583c3f87... ==========
Relanding after fix: https://codereview.chromium.org/2454643002
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== V8: Use new slave-preference function on tryserver BUG=658189 Committed: https://chromium.googlesource.com/chromium/tools/build/+/1978a7f881b4583c3f87... ========== to ========== V8: Use new slave-preference function on tryserver BUG=658189 Committed: https://chromium.googlesource.com/chromium/tools/build/+/1978a7f881b4583c3f87... Committed: https://chromium.googlesource.com/chromium/tools/build/+/f836c59cebc8bc5a41b8... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/f836c59cebc8bc5a41b8... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
