Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2454643002: Fix return value of new slave-distribution function (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Fix return value of new slave-distribution function BUG=658189 Committed: https://chromium.googlesource.com/chromium/tools/build/+/069178d6a5320e5a008d41513837a680ed8634e8

Patch Set 1 : Regression test #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M scripts/master/master_utils.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/master/unittests/master_utils_test.py View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Michael Achenbach
PTAL
4 years, 1 month ago (2016-10-26 08:53:50 UTC) #5
tandrii(chromium)
LGTM
4 years, 1 month ago (2016-10-26 09:38:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454643002/20001
4 years, 1 month ago (2016-10-26 09:43:03 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 09:52:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/069178d6a5320e5a008d...

Powered by Google App Engine
This is Rietveld 408576698