Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2448663003: Ensure queued Channel messages are flushed for in-process renderers (Closed)

Created:
4 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure queued Channel messages are flushed for in-process renderers Previously we were only flushing queued messages in OnProcessLaunched. This means that any messages queued during initialization would never be delivered for in-process renderers. Specifically this can negatively affect webview behavior in production. BUG=656582 R=jam@chromium.org Committed: https://crrev.com/b334cad3032af02c2e9918162cd18739f173797b Cr-Commit-Position: refs/heads/master@{#427211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Ken Rockot(use gerrit already)
4 years, 1 month ago (2016-10-24 23:59:06 UTC) #2
jam
lgtm
4 years, 1 month ago (2016-10-25 00:25:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448663003/1
4 years, 1 month ago (2016-10-25 00:29:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 01:18:40 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 01:21:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b334cad3032af02c2e9918162cd18739f173797b
Cr-Commit-Position: refs/heads/master@{#427211}

Powered by Google App Engine
This is Rietveld 408576698