Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2448573002: Move third_party/gif's license into its own file (Closed)

Created:
4 years, 1 month ago by scroggo_chromium
Modified:
4 years, 1 month ago
Reviewers:
hcm, dogben, scroggo
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revive in-file LICENSE blocks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
A third_party/gif/LICENSE View 1 chunk +37 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
scroggo
https://codereview.chromium.org/2448573002/diff/1/third_party/gif/LICENSE File third_party/gif/LICENSE (right): https://codereview.chromium.org/2448573002/diff/1/third_party/gif/LICENSE#newcode14 third_party/gif/LICENSE:14: * The Original Code is mozilla.org code. I arbitrarily ...
4 years, 1 month ago (2016-10-24 19:20:28 UTC) #3
hcm
On 2016/10/24 19:20:28, scroggo wrote: > https://codereview.chromium.org/2448573002/diff/1/third_party/gif/LICENSE > File third_party/gif/LICENSE (right): > > https://codereview.chromium.org/2448573002/diff/1/third_party/gif/LICENSE#newcode14 > ...
4 years, 1 month ago (2016-10-24 19:26:25 UTC) #4
scroggo
On 2016/10/24 19:26:25, hcm wrote: > On 2016/10/24 19:20:28, scroggo wrote: > > https://codereview.chromium.org/2448573002/diff/1/third_party/gif/LICENSE > ...
4 years, 1 month ago (2016-10-24 19:28:30 UTC) #5
hcm
On 2016/10/24 19:28:30, scroggo wrote: > On 2016/10/24 19:26:25, hcm wrote: > > On 2016/10/24 ...
4 years, 1 month ago (2016-10-24 19:57:33 UTC) #6
scroggo_chromium
On 2016/10/24 19:57:33, hcm wrote: > On 2016/10/24 19:28:30, scroggo wrote: > > On 2016/10/24 ...
4 years, 1 month ago (2016-10-24 20:38:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448573002/20001
4 years, 1 month ago (2016-10-24 20:38:57 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 20:58:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b1094bc692f0a831d49f332e9cdc2abffc112750

Powered by Google App Engine
This is Rietveld 408576698