Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2445653004: Rename GIFImageReader to SkGifImageReader (Closed)

Created:
4 years, 1 month ago by scroggo_chromium
Modified:
4 years, 1 month ago
Reviewers:
scroggo, dogben
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename GIFImageReader to SkGifImageReader The former could violate One Definition Rule in Google3, since other projects that are based on Chrome/webkit also have GIFImageReader. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2445653004 Committed: https://skia.googlesource.com/skia/+/3d3a65c488162ef1db0b35adf3235d012b04c88d

Patch Set 1 #

Patch Set 2 : Remove dependent patch set #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1375 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gyp/codec.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkGifCodec.h View 3 chunks +14 lines, -14 lines 0 comments Download
M src/codec/SkGifCodec.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
D third_party/gif/GIFImageReader.h View 1 chunk +0 lines, -398 lines 0 comments Download
D third_party/gif/GIFImageReader.cpp View 1 chunk +0 lines, -941 lines 0 comments Download
A + third_party/gif/SkGifImageReader.h View 3 chunks +5 lines, -5 lines 1 comment Download
A + third_party/gif/SkGifImageReader.cpp View 8 chunks +8 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
scroggo_chromium
4 years, 1 month ago (2016-10-24 18:47:27 UTC) #3
dogben
lgtm
4 years, 1 month ago (2016-10-24 18:57:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445653004/20001
4 years, 1 month ago (2016-10-24 19:02:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/3d3a65c488162ef1db0b35adf3235d012b04c88d
4 years, 1 month ago (2016-10-24 19:28:33 UTC) #8
dogben
4 years, 1 month ago (2016-10-25 17:32:44 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/2445653004/diff/20001/third_party/gif/SkGifIm...
File third_party/gif/SkGifImageReader.h (right):

https://codereview.chromium.org/2445653004/diff/20001/third_party/gif/SkGifIm...
third_party/gif/SkGifImageReader.h:56: typedef SkTArray<unsigned char, true>
GIFRow;
There are a ton of top-level non-static declarations in this file that still
need to be prefixed.

Powered by Google App Engine
This is Rietveld 408576698