Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2448543002: Remove dead paint flush tracking code. (Closed)

Created:
4 years, 1 month ago by Bryan McQuade
Modified:
4 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead paint flush tracking code. In https://codereview.chromium.org/2437863005, page_load_histograms, which was the only consumer of this code, was removed. Now that the page_load_histograms code has been removed, this code can be removed as well. BUG=657993 Committed: https://crrev.com/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf Cr-Commit-Position: refs/heads/master@{#429329}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -108 lines) Patch
M content/public/renderer/document_state.h View 1 2 chunks +0 lines, -16 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 1 chunk +0 lines, -24 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +0 lines, -46 lines 0 comments Download
M content/renderer/render_widget.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_widget_owner_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Bryan McQuade
avi, PTAL - this removes some now dead code in content/. Thanks!
4 years, 1 month ago (2016-11-02 13:57:51 UTC) #5
Avi (use Gerrit)
lgtm 👍
4 years, 1 month ago (2016-11-02 17:33:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448543002/20001
4 years, 1 month ago (2016-11-02 17:45:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 17:51:19 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 17:56:50 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf
Cr-Commit-Position: refs/heads/master@{#429329}

Powered by Google App Engine
This is Rietveld 408576698