Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2448503002: Revert of Do not hide the old RenderWidgetHostView when commiting a navigation. (Closed)

Created:
4 years, 1 month ago by lfg
Modified:
4 years, 1 month ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not hide the old RenderWidgetHostView when commiting a navigation. (patchset #2 id:20001 of https://codereview.chromium.org/2415973002/ ) Reason for revert: Caused a regression on Mac. BUG=658688 Original issue's description: > Do not hide the old RenderWidgetHostView when commiting a navigation. > > This fixes an issue where the old RenderView is reused by a new remote > subframe. We shouldn't be leaking resources, because now we are already > hiding the unused RenderView in the renderer, when the local main frame > gets detached and the WebViewFrameWidget is closed. > > BUG=638375 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/7c3d7bbd510eda2bcfb971f6d166da26bcfe4222 > Cr-Commit-Position: refs/heads/master@{#426913} TBR=creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=638375 Committed: https://crrev.com/4b746a0ef62cc611f7b79b4cc6a2d7cebb982f3e Cr-Commit-Position: refs/heads/master@{#427091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -26 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
lfg
Created Revert of Do not hide the old RenderWidgetHostView when commiting a navigation.
4 years, 1 month ago (2016-10-24 15:21:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448503002/1
4 years, 1 month ago (2016-10-24 15:21:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 17:25:25 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 17:50:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b746a0ef62cc611f7b79b4cc6a2d7cebb982f3e
Cr-Commit-Position: refs/heads/master@{#427091}

Powered by Google App Engine
This is Rietveld 408576698