Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 2448503002: Revert of Do not hide the old RenderWidgetHostView when commiting a navigation. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/site_per_process_browsertest.cc
diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc
index d59417aa811b823702d48cb410d4edbcb744cb5d..67ff7ca2eee5792ba26c4f2bac9b60a00a32501a 100644
--- a/content/browser/site_per_process_browsertest.cc
+++ b/content/browser/site_per_process_browsertest.cc
@@ -8522,30 +8522,4 @@
EXPECT_EQ(expected_title, title_watcher.WaitAndGetTitle());
}
-// This tests that we don't hide the RenderViewHost when reusing the
-// RenderViewHost for a subframe. See https://crbug.com/638375.
-IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, ReusedRenderViewNotHidden) {
- GURL a_url(embedded_test_server()->GetURL("a.com", "/title1.html"));
- GURL b_url_a_subframe(embedded_test_server()->GetURL(
- "b.com", "/cross_site_iframe_factory.html?b(a)"));
-
- EXPECT_TRUE(NavigateToURL(shell(), a_url));
-
- // Open a popup in a.com.
- Shell* popup = OpenPopup(shell(), a_url, "popup");
-
- // Navigate this popup to b.com with an a.com subframe.
- EXPECT_TRUE(NavigateToURL(popup, b_url_a_subframe));
-
- FrameTreeNode* root = static_cast<WebContentsImpl*>(popup->web_contents())
- ->GetFrameTree()
- ->root();
- FrameTreeNode* child_node = root->child_at(0);
-
- EXPECT_FALSE(child_node->current_frame_host()
- ->render_view_host()
- ->GetWidget()
- ->is_hidden());
-}
-
} // namespace content
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698