Move ignore_elf32_limitations into build_overrides/build.gni

Move ignore_elf32_limitations into build_overrides/build.gni

Having this it will be easy for client projects to override
the ignore_elf32_limitations flag that was added in
https://codereview.chromium.org/2395603003 by setting it to true
in their own build_overrides/build.gni.
Then it will still be possible to build with symbol_level=2 as
long as the project isn't affected by the 4GB size limit.

BUG=648948, webrtc:6596
Committed: https://crrev.com/fd77254d72956d5e469857b2242fefc7f95fc407
Cr-Commit-Position: refs/heads/master@{#427608}

[kjellander_chromium, 2016-10-24 13:12:50]

Description was changed from

==========
Move ignore_elf32_limitations into build_overrides/build.gni

Having this it will be easy for client projects to override
the ignore_elf32_limitations flag that was added in
https://codereview.chromium.org/2395603003 by setting it to true
in their own build_overrides/build.gni.
Then it will still be possible to build with symbol_level=2 as
long as the project isn't affected by the 4GB size limit.

BUG=648948
==========

to

==========
Move ignore_elf32_limitations into build_overrides/build.gni

Having this it will be easy for client projects to override
the ignore_elf32_limitations flag that was added in
https://codereview.chromium.org/2395603003 by setting it to true
in their own build_overrides/build.gni.
Then it will still be possible to build with symbol_level=2 as
long as the project isn't affected by the 4GB size limit.

BUG=648948, webrtc:6596
==========

[kjellander_chromium, 2016-10-24 13:12:50]

kjellander@chromium.org changed reviewers:
+ dpranke@chromium.org, machenbach@chromium.org

[kjellander_chromium, 2016-10-24 13:13:51]

Can we get this? It would make our builds cleaner and reduce work having to
inform all users about an additional GN arg to set.

[kjellander_chromium, 2016-10-24 13:13:55]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 13:14:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-10-24 13:18:08]

Liked by V8. Non-owner lgtm.

https://codereview.chromium.org/2448453002/diff/1/build/config/compiler/compi...
File build/config/compiler/compiler.gni (left):

https://codereview.chromium.org/2448453002/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:54: ignore_elf32_limitations = false
This was a gn arg before. Maybe keep it as a gn arg in build.gni? Not sure if
anyone wants to alter it on another than on project level.

[commit-bot: I haz the power, 2016-10-24 14:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 14:37:45]

Dry run: This issue passed the CQ dry run.

[kjellander_chromium, 2016-10-25 19:04:41]

kjellander@chromium.org changed reviewers:
+ thakis@chromium.org

[kjellander_chromium, 2016-10-25 19:04:41]

+thakis since I didn't realize Dirk was OOO.

https://codereview.chromium.org/2448453002/diff/1/build/config/compiler/compi...
File build/config/compiler/compiler.gni (left):

https://codereview.chromium.org/2448453002/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:54: ignore_elf32_limitations = false
On 2016/10/24 13:18:07, machenbach (slow) wrote:
> This was a gn arg before. Maybe keep it as a gn arg in build.gni? Not sure if
> anyone wants to alter it on another than on project level.

Ah, you're right. Fixed in PS#2.

[Nico, 2016-10-25 19:18:18]

lgtm :-/

[kjellander_chromium, 2016-10-26 05:23:32]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-10-26 05:23:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2448453002/#ps20001
(title: "Made it a gn arg")

[commit-bot: I haz the power, 2016-10-26 05:23:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 06:26:16]

Description was changed from

==========
Move ignore_elf32_limitations into build_overrides/build.gni

Having this it will be easy for client projects to override
the ignore_elf32_limitations flag that was added in
https://codereview.chromium.org/2395603003 by setting it to true
in their own build_overrides/build.gni.
Then it will still be possible to build with symbol_level=2 as
long as the project isn't affected by the 4GB size limit.

BUG=648948, webrtc:6596
==========

to

==========
Move ignore_elf32_limitations into build_overrides/build.gni

Having this it will be easy for client projects to override
the ignore_elf32_limitations flag that was added in
https://codereview.chromium.org/2395603003 by setting it to true
in their own build_overrides/build.gni.
Then it will still be possible to build with symbol_level=2 as
long as the project isn't affected by the 4GB size limit.

BUG=648948, webrtc:6596
==========

[commit-bot: I haz the power, 2016-10-26 06:26:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 06:28:03]

Description was changed from

==========
Move ignore_elf32_limitations into build_overrides/build.gni

Having this it will be easy for client projects to override
the ignore_elf32_limitations flag that was added in
https://codereview.chromium.org/2395603003 by setting it to true
in their own build_overrides/build.gni.
Then it will still be possible to build with symbol_level=2 as
long as the project isn't affected by the 4GB size limit.

BUG=648948, webrtc:6596
==========

to

==========
Move ignore_elf32_limitations into build_overrides/build.gni

Having this it will be easy for client projects to override
the ignore_elf32_limitations flag that was added in
https://codereview.chromium.org/2395603003 by setting it to true
in their own build_overrides/build.gni.
Then it will still be possible to build with symbol_level=2 as
long as the project isn't affected by the 4GB size limit.

BUG=648948, webrtc:6596

Committed: https://crrev.com/fd77254d72956d5e469857b2242fefc7f95fc407
Cr-Commit-Position: refs/heads/master@{#427608}
==========

[commit-bot: I haz the power, 2016-10-26 06:28:04]

Patchset 2 (id:??) landed as
https://crrev.com/fd77254d72956d5e469857b2242fefc7f95fc407
Cr-Commit-Position: refs/heads/master@{#427608}

[Dirk Pranke, 2016-10-26 18:26:13]

lgtm