Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2395603003:
Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni (Closed)
DescriptionAdd a ignore_elf32_limitations flag in build/config/compiler/compiler.gni
Add a ignore_elf32_limitations flag in
build/config/compiler/compiler.gni to turn off
assertion for Cronet builds.
This CL additionally adds is_clang to the
assertion per comment in 648948.
BUG=651887, 648948
Committed: https://crrev.com/6d32a26068321e5976494501c51a33636a42c13f
Cr-Commit-Position: refs/heads/master@{#423564}
Patch Set 1 #Patch Set 2 : Address dpranke@ comments #Patch Set 3 : address torne's comment to add is_clang #
Dependent Patchsets: Messages
Total messages: 27 (18 generated)
Patchset #1 (id:1) has been deleted
xunjieli@chromium.org changed reviewers: + dpranke@chromium.org, mef@chromium.org, torne@chromium.org
Description was changed from ========== Ignore Cronet builds in compiler assertion Unstripped Cronet binaries are not reaching 4gb any time soon, so ignore the compiler assertion for now. BUG=651887 ========== to ========== Skip Cronet builds in compiler assertion Unstripped Cronet binaries are not reaching 4gb any time soon, so ignore the compiler assertion for now. BUG=651887 ==========
The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I would like to avoid adding an `is_cronet` flag and file to //build. How about adding a generic flag to compiler.gni called something like `allow_full_symbols` or `override_symbol_level_check` instead? This would also allow people building non-cronet android binaries to get full symbols if it's safe to do so.
Patchset #2 (id:40001) has been deleted
Done. Thanks. PTAL
Description was changed from ========== Skip Cronet builds in compiler assertion Unstripped Cronet binaries are not reaching 4gb any time soon, so ignore the compiler assertion for now. BUG=651887 ========== to ========== Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni Add a Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni to turn off assertion for Cronet builds. BUG=651887 ==========
Description was changed from ========== Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni Add a Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni to turn off assertion for Cronet builds. BUG=651887 ========== to ========== Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni to turn off assertion for Cronet builds. BUG=651887 ==========
lgtm
The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
This change LGTM, but while you're already updating this, can you also add "|| is_clang" to the assertion, per recent comments on crbug.com/648948? Clang's debug information is much smaller and so clang builds are also not going to exceed 4GiB any time soon.
Description was changed from ========== Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni to turn off assertion for Cronet builds. BUG=651887 ========== to ========== Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni to turn off assertion for Cronet builds. BUG=651887,648948 ==========
On 2016/10/06 11:13:00, Torne wrote: > This change LGTM, but while you're already updating this, can you also add "|| > is_clang" to the assertion, per recent comments on crbug.com/648948? Clang's > debug information is much smaller and so clang builds are also not going to > exceed 4GiB any time soon. Done. Thanks!
The CQ bit was checked by xunjieli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, torne@chromium.org Link to the patchset: https://codereview.chromium.org/2395603003/#ps80001 (title: "address torne's comment to add is_clang")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni to turn off assertion for Cronet builds. BUG=651887,648948 ========== to ========== Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni to turn off assertion for Cronet builds. This CL additionally adds is_clang to the assertion per comment in 648948. BUG=651887,648948 ==========
Message was sent while issue was closed.
Description was changed from ========== Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni to turn off assertion for Cronet builds. This CL additionally adds is_clang to the assertion per comment in 648948. BUG=651887,648948 ========== to ========== Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni to turn off assertion for Cronet builds. This CL additionally adds is_clang to the assertion per comment in 648948. BUG=651887,648948 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni to turn off assertion for Cronet builds. This CL additionally adds is_clang to the assertion per comment in 648948. BUG=651887,648948 ========== to ========== Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni to turn off assertion for Cronet builds. This CL additionally adds is_clang to the assertion per comment in 648948. BUG=651887,648948 Committed: https://crrev.com/6d32a26068321e5976494501c51a33636a42c13f Cr-Commit-Position: refs/heads/master@{#423564} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6d32a26068321e5976494501c51a33636a42c13f Cr-Commit-Position: refs/heads/master@{#423564} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
