third_party: Revise version 3 of remote shell protocol

third_party: Revise version 3 of remote shell protocol

This CL generalizes remote shell configuration to multiple workspaces,
which enables the client-side window manager to perform window layout
for each server-side display in extended desktop mode.

BUG=642894
TEST=None

Review-Url: https://codereview.chromium.org/2448413002
Cr-Commit-Position: refs/heads/master@{#457216}
Committed: https://chromium.googlesource.com/chromium/src/+/75a381ed7a4db48f000c09a31e20c39b11c10a59

[Dominik Laskowski, 2016-10-26 01:51:51]

The CQ bit was checked by domlaskowski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 01:52:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dominik Laskowski, 2016-10-26 01:53:16]

domlaskowski@chromium.org changed reviewers:
+ oshima@chromium.org, reveman@chromium.org

[Dominik Laskowski, 2016-10-26 01:53:17]

PTAL.

[commit-bot: I haz the power, 2016-10-26 02:22:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 02:22:37]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[reveman, 2016-10-26 15:13:45]

https://codereview.chromium.org/2448413002/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2448413002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:157:
</event>
I understand that inset is the workspace but what is x, y, width, height? does
wl_output::geometry already provide that information?

how does the client know that it received all workspace events? wl_output::done?


fyi, I'd like to make remote-shell more appropriately layered on top of existing
extensions in the near future. aura_shell extends xdg_shell with minimal changes
and aura_output extends wl_output, etc.

[Dominik Laskowski, 2016-10-26 19:53:10]

https://codereview.chromium.org/2448413002/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2448413002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:157:
</event>
On 2016/10/26 15:13:44, reveman wrote:
> I understand that inset is the workspace but what is x, y, width, height? does
> wl_output::geometry already provide that information?
> 
> how does the client know that it received all workspace events?
wl_output::done?
> 
> 
> fyi, I'd like to make remote-shell more appropriately layered on top of
existing
> extensions in the near future. aura_shell extends xdg_shell with minimal
changes
> and aura_output extends wl_output, etc.

Bounds of the workspace in virtual coordinates, i.e. within the display defined
by the subsequent "configure" event. wl_output doesn't map very well to our
concept of virtual displays. wl_output::geometry provides position (though in
compositor space, i.e. screen coordinates) and wl_output::mode provides
resolution. However, the other arguments are inapplicable, and workspaces also
require an ID and insets.

The "workspace" events are always terminated by a "configure" event.

Unless we migrate all window management to the server, I'm not sure how this
layering would work, because in certain cases the upstream interfaces are
incompatible with the hybrid window management.

[reveman, 2016-11-11 01:36:14]

lgtm

https://codereview.chromium.org/2448413002/diff/1/third_party/wayland-protoco...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2448413002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:157:
</event>
On 2016/10/26 at 19:53:10, Dominik Laskowski wrote:
> On 2016/10/26 15:13:44, reveman wrote:
> > I understand that inset is the workspace but what is x, y, width, height?
does
> > wl_output::geometry already provide that information?
> > 
> > how does the client know that it received all workspace events?
wl_output::done?
> > 
> > 
> > fyi, I'd like to make remote-shell more appropriately layered on top of
existing
> > extensions in the near future. aura_shell extends xdg_shell with minimal
changes
> > and aura_output extends wl_output, etc.
> 
> Bounds of the workspace in virtual coordinates, i.e. within the display
defined by the subsequent "configure" event. wl_output doesn't map very well to
our concept of virtual displays. wl_output::geometry provides position (though
in compositor space, i.e. screen coordinates) and wl_output::mode provides
resolution. However, the other arguments are inapplicable, and workspaces also
require an ID and insets.

Ok, makes sense.

> 
> The "workspace" events are always terminated by a "configure" event.

Got it. A short comment about that in the event description would be nice.

> 
> Unless we migrate all window management to the server, I'm not sure how this
layering would work, because in certain cases the upstream interfaces are
incompatible with the hybrid window management.

aura_output extending wl_output doesn't make sense know that I better understand
the difference between wl_output and the workspace we need here. However,
remote_shell becoming an interface layered on top of xdg_shell is something we
want to do in the near future but no need to worry about that now.

[Dominik Laskowski, 2017-02-10 19:34:58]

Description was changed from

==========
third_party: Update remote shell protocol to version 3

This CL generalizes remote shell configuration to multiple workspaces,
which enables the client-side window manager to perform window layout
for each server-side display in extended desktop mode.

BUG=642894
TEST=None
==========

to

==========
third_party: Update remote shell protocol to version 4

This CL generalizes remote shell configuration to multiple workspaces,
which enables the client-side window manager to perform window layout
for each server-side display in extended desktop mode.

BUG=642894
TEST=None
==========

[Dominik Laskowski, 2017-02-10 20:53:44]

On 2016/11/11 01:36:14, reveman wrote:
> Got it. A short comment about that in the event description would be nice.

Done.

[Dominik Laskowski, 2017-03-15 20:19:03]

Description was changed from

==========
third_party: Update remote shell protocol to version 4

This CL generalizes remote shell configuration to multiple workspaces,
which enables the client-side window manager to perform window layout
for each server-side display in extended desktop mode.

BUG=642894
TEST=None
==========

to

==========
third_party: Revise version 3 of remote shell protocol

This CL generalizes remote shell configuration to multiple workspaces,
which enables the client-side window manager to perform window layout
for each server-side display in extended desktop mode.

BUG=642894
TEST=None
==========

[Dominik Laskowski, 2017-03-15 20:27:04]

The CQ bit was checked by domlaskowski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 20:27:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dominik Laskowski, 2017-03-15 20:36:06]

PTAL. The new display configuration protocol has been folded into version 3.

[commit-bot: I haz the power, 2017-03-15 20:59:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:59:43]

Dry run: This issue passed the CQ dry run.

[reveman, 2017-03-15 21:08:29]

lgtm

[Dominik Laskowski, 2017-03-15 21:24:01]

The CQ bit was checked by domlaskowski@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:24:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 21:40:57]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489613041169890,
"parent_rev": "fa183c4a45279af055329164c6267e03f3280e39", "commit_rev":
"75a381ed7a4db48f000c09a31e20c39b11c10a59"}

[commit-bot: I haz the power, 2017-03-15 21:42:46]

Description was changed from

==========
third_party: Revise version 3 of remote shell protocol

This CL generalizes remote shell configuration to multiple workspaces,
which enables the client-side window manager to perform window layout
for each server-side display in extended desktop mode.

BUG=642894
TEST=None
==========

to

==========
third_party: Revise version 3 of remote shell protocol

This CL generalizes remote shell configuration to multiple workspaces,
which enables the client-side window manager to perform window layout
for each server-side display in extended desktop mode.

BUG=642894
TEST=None

Review-Url: https://codereview.chromium.org/2448413002
Cr-Commit-Position: refs/heads/master@{#457216}
Committed:
https://chromium.googlesource.com/chromium/src/+/75a381ed7a4db48f000c09a31e20...
==========

[commit-bot: I haz the power, 2017-03-15 21:42:47]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/75a381ed7a4db48f000c09a31e20...