Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2448403002: cc: Clean up transform tree (Closed)

Created:
4 years, 1 month ago by jaydasika
Modified:
4 years, 1 month ago
Reviewers:
ajuma, weiliangc, pdr.
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Clean up transform tree This CL deletes: 1) surface contents scale on transfrom tree TransformNode::needs_surface_contents_scale, TransformNode::surface_contents_scale, TransformTree::UpdateSurfaceContentsScale, DrawPropertyUtils::VerifySurfaceContentsScalesMatch 2) Dead code DrawPropertyUtils::VerifyTransformTreeCalculations, TransformTree::UpdateTargetSpaceTransform, TransformCachedNodeData::(from_target, to_target) 3) Redundant stuff in PropertyTrees TransfromTree::(ToTarget, FromTarget, SetToTarget, SetFromTarget), PropertyTrees::ComputeTransformToTarget, TransformTree::ComputeTransform is now used only in tests BUG=622372 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/b433552b9bfc3ade27dfe7a4b95496f609ba4c35 Cr-Commit-Position: refs/heads/master@{#427763}

Patch Set 1 #

Patch Set 2 : PAC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -552 lines) Patch
M cc/proto/property_tree.proto View 3 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/draw_property_utils.h View 2 chunks +3 lines, -7 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 25 chunks +65 lines, -180 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M cc/trees/property_tree.h View 4 chunks +3 lines, -17 lines 0 comments Download
M cc/trees/property_tree.cc View 10 chunks +13 lines, -110 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/property_tree_unittest.cc View 18 chunks +43 lines, -176 lines 0 comments Download
M cc/trees/transform_node.h View 3 chunks +0 lines, -6 lines 0 comments Download
M cc/trees/transform_node.cc View 9 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
jaydasika
PTAL sunxd : Most of this is possible because of your patch. If you already ...
4 years, 1 month ago (2016-10-26 01:28:30 UTC) #7
sunxd
On 2016/10/26 01:28:30, jaydasika wrote: > PTAL > > sunxd : Most of this is ...
4 years, 1 month ago (2016-10-26 14:17:49 UTC) #16
weiliangc
LGTM
4 years, 1 month ago (2016-10-26 17:38:45 UTC) #17
jaydasika
pdr: Please review changes in PaintArtifactCompositor
4 years, 1 month ago (2016-10-26 17:40:45 UTC) #19
pdr.
On 2016/10/26 at 17:40:45, jaydasika wrote: > pdr: Please review changes in PaintArtifactCompositor LGTM
4 years, 1 month ago (2016-10-26 17:43:29 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448403002/20001
4 years, 1 month ago (2016-10-26 17:44:39 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 18:50:07 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 18:53:43 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b433552b9bfc3ade27dfe7a4b95496f609ba4c35
Cr-Commit-Position: refs/heads/master@{#427763}

Powered by Google App Engine
This is Rietveld 408576698