Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2448253002: Extract SVG transform update from PaintPropertyTreeBuilder::updateTransform (Closed)

Created:
4 years, 1 month ago by pdr.
Modified:
4 years, 1 month ago
Reviewers:
Xianzhu, trchen
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract SVG transform update from PaintPropertyTreeBuilder::updateTransform This refactoring simplifies updateTransform which now only handles the general transform update, with SVG handled in a separate function. BUG=645667 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/dc2eede366a908159336da0070ac804ba25de929 Cr-Commit-Position: refs/heads/master@{#427465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -63 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +72 lines, -63 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pdr.
Just a small cleanup. This should make future diffs easier to follow.
4 years, 1 month ago (2016-10-25 19:26:51 UTC) #3
Xianzhu
lgtm
4 years, 1 month ago (2016-10-25 19:31:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448253002/1
4 years, 1 month ago (2016-10-25 20:55:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 21:01:11 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 21:03:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc2eede366a908159336da0070ac804ba25de929
Cr-Commit-Position: refs/heads/master@{#427465}

Powered by Google App Engine
This is Rietveld 408576698