Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 24482004: events: Make platform specific events code into ui/events/. (Closed)

Created:
7 years, 3 months ago by sadrul
Modified:
7 years, 3 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, dcheng, joi+watch-content_chromium.org, scheib+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

events: Make platform specific events code into ui/events/. Notable changes: * Move events_win and events_x from ui/base/ into ui/events/ * Move DeviceDataManager, and DeviceListCache into ui/events/ * Move X11AtomCache from ui/base/x into ui/gfx/x * Move some X11 util functions from ui/base/ into ui/events/ BUG=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225163

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -2759 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_hud_debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/sticky_keys_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/device_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/keyboard_driven_event_rewriter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/event_rewriter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/apps/native_app_window_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/web_input_event_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window_host_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window_host_x11.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/test/event_generator.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/base/clipboard/clipboard_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/touch/touch_factory_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/base/win/events_win.cc View 1 chunk +0 lines, -372 lines 0 comments Download
D ui/base/x/device_data_manager.h View 1 chunk +0 lines, -293 lines 0 comments Download
D ui/base/x/device_data_manager.cc View 1 chunk +0 lines, -586 lines 0 comments Download
D ui/base/x/device_list_cache_x.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ui/base/x/device_list_cache_x.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D ui/base/x/events_x.cc View 1 chunk +0 lines, -755 lines 0 comments Download
D ui/base/x/events_x_unittest.cc View 1 chunk +0 lines, -335 lines 0 comments Download
M ui/base/x/selection_owner.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/selection_requestor.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/selection_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/selection_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/base/x/x11_atom_cache.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/base/x/x11_atom_cache.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M ui/base/x/x11_util.h View 1 chunk +0 lines, -17 lines 0 comments Download
M ui/base/x/x11_util.cc View 4 chunks +1 line, -106 lines 0 comments Download
M ui/events/event_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + ui/events/win/events_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/events/x/device_data_manager.h View 5 chunks +16 lines, -6 lines 0 comments Download
A + ui/events/x/device_data_manager.cc View 4 chunks +17 lines, -4 lines 0 comments Download
A + ui/events/x/device_list_cache_x.h View 4 chunks +5 lines, -5 lines 0 comments Download
A + ui/events/x/device_list_cache_x.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + ui/events/x/events_x.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/events/x/events_x_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/events/x/events_x_utils.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ui/events/x/events_x_utils.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A + ui/gfx/x/x11_atom_cache.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/gfx/x/x11_atom_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui.gyp View 7 chunks +12 lines, -9 lines 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
There is still dependency on TouchFactory for X11, and some switches need to be moved ...
7 years, 3 months ago (2013-09-25 03:40:31 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 3 months ago (2013-09-25 04:13:26 UTC) #2
sadrul
7 years, 3 months ago (2013-09-25 09:15:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r225163 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698