Reland of gpu: Clarify sized texture format is available (https://codereview.chromium.org/211718300…

Reland of gpu: Clarify sized texture format is available (https://codereview.chromium.org/2117183006)

Reason for revert:
r425684 causes blank video of mediaStream playback in MacOSX, because MacOSX
relies on the hack, which the CL removed. This CL remains the hack only in MacOSX.

BUG=535198, 657532
> Revert of gpu: Clarify sized texture format is available only if ES3 context or immutable texture is supported (patchset #7 id:160001 of https://codereview.chromium.org/2117183006/ )
>
> Reason for revert:
> Broke playing back recorded data as detailed
> in https://crbug.com/657532.  The bug has
> step-by-step notes on how to repro (see also #4
> in there).
>
> Locally reverting of this CL restores the functionality.
>
> Original issue's description:
> > gpu: Clarify the sized texture format is available only if ES3 context or immutable texture is supported.
> >
> > This clarification makes it possible that gles2 decoder tracks true internal format of immutable texture. So this CL removes internal_format hack in GLES2DecoderImpl::TexStorageImpl()
> >
> > In addition, it makes CMAA skip redundant copy path because CMAA can know true internal format.
> >
> > BUG=535198
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/730f8089f791fa31a3ee2a7f5059a1052b129d21
> > Cr-Commit-Position: refs/heads/master@{#425684}
>
> TBR=dongseong.hwang@chromium.org,zmo@chromium.org,kbr@chromium.org,dongseong.hwang@intel.com
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=535198
>
> Review-Url: https://codereview.chromium.org/2443123004
> Cr-Commit-Position: refs/heads/master@{#427229}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/460cac969e2e9ac38a2611be1a32db0361d88bfb
Cr-Commit-Position: refs/heads/master@{#427473}

[dshwang, 2016-10-25 13:03:38]

Description was changed from

==========
Reland of gpu: Clarify sized texture format is available
(https://codereview.chromium.org/2117183006)

Reason for revert:
r425684 causes blank video of mediaStream playback in MacOSX, because MacOSX
relies on the hace, which the CL removed. This CL remains the hack only in
MacOSX.

BUG=535198, 657532

> Revert of gpu: Clarify sized texture format is available only if ES3 context
or immutable texture is supported (patchset #7 id:160001 of
https://codereview.chromium.org/2117183006/ )
>
> Reason for revert:
> Broke playing back recorded data as detailed
> in https://crbug.com/657532.  The bug has
> step-by-step notes on how to repro (see also #4
> in there).
>
> Locally reverting of this CL restores the functionality.
>
> Original issue's description:
> > gpu: Clarify the sized texture format is available only if ES3 context or
immutable texture is supported.
> >
> > This clarification makes it possible that gles2 decoder tracks true internal
format of immutable texture. So this CL removes internal_format hack in
GLES2DecoderImpl::TexStorageImpl()
> >
> > In addition, it makes CMAA skip redundant copy path because CMAA can know
true internal format.
> >
> > BUG=535198
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/730f8089f791fa31a3ee2a7f5059a1052b129d21
> > Cr-Commit-Position: refs/heads/master@{#425684}
>
>
TBR=dongseong.hwang@chromium.org,zmo@chromium.org,kbr@chromium.org,dongseong....
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=535198
>
> Review-Url: https://codereview.chromium.org/2443123004
> Cr-Commit-Position: refs/heads/master@{#427229}
==========

to

==========
Reland of gpu: Clarify sized texture format is available
(https://codereview.chromium.org/2117183006)

Reason for revert:
r425684 causes blank video of mediaStream playback in MacOSX, because MacOSX
relies on the hace, which the CL removed. This CL remains the hack only in
MacOSX.

BUG=535198, 657532

> Revert of gpu: Clarify sized texture format is available only if ES3 context
or immutable texture is supported (patchset #7 id:160001 of
https://codereview.chromium.org/2117183006/ )
>
> Reason for revert:
> Broke playing back recorded data as detailed
> in https://crbug.com/657532.  The bug has
> step-by-step notes on how to repro (see also #4
> in there).
>
> Locally reverting of this CL restores the functionality.
>
> Original issue's description:
> > gpu: Clarify the sized texture format is available only if ES3 context or
immutable texture is supported.
> >
> > This clarification makes it possible that gles2 decoder tracks true internal
format of immutable texture. So this CL removes internal_format hack in
GLES2DecoderImpl::TexStorageImpl()
> >
> > In addition, it makes CMAA skip redundant copy path because CMAA can know
true internal format.
> >
> > BUG=535198
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/730f8089f791fa31a3ee2a7f5059a1052b129d21
> > Cr-Commit-Position: refs/heads/master@{#425684}
>
>
TBR=dongseong.hwang@chromium.org,zmo@chromium.org,kbr@chromium.org,dongseong....
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=535198
>
> Review-Url: https://codereview.chromium.org/2443123004
> Cr-Commit-Position: refs/heads/master@{#427229}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[inactive_dshwang_plz_cc_intel, 2016-10-25 13:05:04]

The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 13:05:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dshwang, 2016-10-25 13:11:28]

dongseong.hwang@intel.com changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[dshwang, 2016-10-25 13:11:29]

zmo@, could you review to reland https://codereview.chromium.org/2117183006?

The CL corrects internal format of immutable texture, but the CL was reverted
because it breaks MacOSX video playback. I try to reproduce the bug using
ChromeOS and Linux, but I cannot. MacOSX HW decoding code must have the root
bug, which relies on the hack. However, I don't have MacOSX, so currently cannot
debug and fix it.

So my suggestion is to reland the reverted CL with MacOSX treatment (temporary
hack), because
1. the CL removes hack, to prevent other platforms from relying on the hack like
MacOSX.
2. mac developers can reproduce it easily by commenting out one line.

What do you think?

[commit-bot: I haz the power, 2016-10-25 13:52:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 13:52:46]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-10-25 16:56:40]

On 2016/10/25 13:11:29, dshwang wrote:
> zmo@, could you review to reland https://codereview.chromium.org/2117183006
> 
> The CL corrects internal format of immutable texture, but the CL was reverted
> because it breaks MacOSX video playback. I try to reproduce the bug using
> ChromeOS and Linux, but I cannot. MacOSX HW decoding code must have the root
> bug, which relies on the hack. However, I don't have MacOSX, so currently
cannot
> debug and fix it.
> 
> So my suggestion is to reland the reverted CL with MacOSX treatment (temporary
> hack), because
> 1. the CL removes hack, to prevent other platforms from relying on the hack
like
> MacOSX.
> 2. mac developers can reproduce it easily by commenting out one line.
> 
> What do you think?

lgtm
but please make sure the bug doesn't get closed after this lands.

[Ken Russell (switch to Gerrit), 2016-10-25 16:58:30]

Description was changed from

==========
Reland of gpu: Clarify sized texture format is available
(https://codereview.chromium.org/2117183006)

Reason for revert:
r425684 causes blank video of mediaStream playback in MacOSX, because MacOSX
relies on the hace, which the CL removed. This CL remains the hack only in
MacOSX.

BUG=535198, 657532

> Revert of gpu: Clarify sized texture format is available only if ES3 context
or immutable texture is supported (patchset #7 id:160001 of
https://codereview.chromium.org/2117183006/ )
>
> Reason for revert:
> Broke playing back recorded data as detailed
> in https://crbug.com/657532.  The bug has
> step-by-step notes on how to repro (see also #4
> in there).
>
> Locally reverting of this CL restores the functionality.
>
> Original issue's description:
> > gpu: Clarify the sized texture format is available only if ES3 context or
immutable texture is supported.
> >
> > This clarification makes it possible that gles2 decoder tracks true internal
format of immutable texture. So this CL removes internal_format hack in
GLES2DecoderImpl::TexStorageImpl()
> >
> > In addition, it makes CMAA skip redundant copy path because CMAA can know
true internal format.
> >
> > BUG=535198
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/730f8089f791fa31a3ee2a7f5059a1052b129d21
> > Cr-Commit-Position: refs/heads/master@{#425684}
>
>
TBR=dongseong.hwang@chromium.org,zmo@chromium.org,kbr@chromium.org,dongseong....
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=535198
>
> Review-Url: https://codereview.chromium.org/2443123004
> Cr-Commit-Position: refs/heads/master@{#427229}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reland of gpu: Clarify sized texture format is available
(https://codereview.chromium.org/2117183006)

Reason for revert:
r425684 causes blank video of mediaStream playback in MacOSX, because MacOSX
relies on the hack, which the CL removed. This CL remains the hack only in
MacOSX.

BUG=535198, 657532

> Revert of gpu: Clarify sized texture format is available only if ES3 context
or immutable texture is supported (patchset #7 id:160001 of
https://codereview.chromium.org/2117183006/ )
>
> Reason for revert:
> Broke playing back recorded data as detailed
> in https://crbug.com/657532.  The bug has
> step-by-step notes on how to repro (see also #4
> in there).
>
> Locally reverting of this CL restores the functionality.
>
> Original issue's description:
> > gpu: Clarify the sized texture format is available only if ES3 context or
immutable texture is supported.
> >
> > This clarification makes it possible that gles2 decoder tracks true internal
format of immutable texture. So this CL removes internal_format hack in
GLES2DecoderImpl::TexStorageImpl()
> >
> > In addition, it makes CMAA skip redundant copy path because CMAA can know
true internal format.
> >
> > BUG=535198
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/730f8089f791fa31a3ee2a7f5059a1052b129d21
> > Cr-Commit-Position: refs/heads/master@{#425684}
>
>
TBR=dongseong.hwang@chromium.org,zmo@chromium.org,kbr@chromium.org,dongseong....
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=535198
>
> Review-Url: https://codereview.chromium.org/2443123004
> Cr-Commit-Position: refs/heads/master@{#427229}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[dshwang, 2016-10-25 21:07:37]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2016-10-25 21:08:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 21:17:07]

Description was changed from

==========
Reland of gpu: Clarify sized texture format is available
(https://codereview.chromium.org/2117183006)

Reason for revert:
r425684 causes blank video of mediaStream playback in MacOSX, because MacOSX
relies on the hack, which the CL removed. This CL remains the hack only in
MacOSX.

BUG=535198, 657532

> Revert of gpu: Clarify sized texture format is available only if ES3 context
or immutable texture is supported (patchset #7 id:160001 of
https://codereview.chromium.org/2117183006/ )
>
> Reason for revert:
> Broke playing back recorded data as detailed
> in https://crbug.com/657532.  The bug has
> step-by-step notes on how to repro (see also #4
> in there).
>
> Locally reverting of this CL restores the functionality.
>
> Original issue's description:
> > gpu: Clarify the sized texture format is available only if ES3 context or
immutable texture is supported.
> >
> > This clarification makes it possible that gles2 decoder tracks true internal
format of immutable texture. So this CL removes internal_format hack in
GLES2DecoderImpl::TexStorageImpl()
> >
> > In addition, it makes CMAA skip redundant copy path because CMAA can know
true internal format.
> >
> > BUG=535198
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/730f8089f791fa31a3ee2a7f5059a1052b129d21
> > Cr-Commit-Position: refs/heads/master@{#425684}
>
>
TBR=dongseong.hwang@chromium.org,zmo@chromium.org,kbr@chromium.org,dongseong....
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=535198
>
> Review-Url: https://codereview.chromium.org/2443123004
> Cr-Commit-Position: refs/heads/master@{#427229}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reland of gpu: Clarify sized texture format is available
(https://codereview.chromium.org/2117183006)

Reason for revert:
r425684 causes blank video of mediaStream playback in MacOSX, because MacOSX
relies on the hack, which the CL removed. This CL remains the hack only in
MacOSX.

BUG=535198, 657532

> Revert of gpu: Clarify sized texture format is available only if ES3 context
or immutable texture is supported (patchset #7 id:160001 of
https://codereview.chromium.org/2117183006/ )
>
> Reason for revert:
> Broke playing back recorded data as detailed
> in https://crbug.com/657532.  The bug has
> step-by-step notes on how to repro (see also #4
> in there).
>
> Locally reverting of this CL restores the functionality.
>
> Original issue's description:
> > gpu: Clarify the sized texture format is available only if ES3 context or
immutable texture is supported.
> >
> > This clarification makes it possible that gles2 decoder tracks true internal
format of immutable texture. So this CL removes internal_format hack in
GLES2DecoderImpl::TexStorageImpl()
> >
> > In addition, it makes CMAA skip redundant copy path because CMAA can know
true internal format.
> >
> > BUG=535198
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/730f8089f791fa31a3ee2a7f5059a1052b129d21
> > Cr-Commit-Position: refs/heads/master@{#425684}
>
>
TBR=dongseong.hwang@chromium.org,zmo@chromium.org,kbr@chromium.org,dongseong....
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=535198
>
> Review-Url: https://codereview.chromium.org/2443123004
> Cr-Commit-Position: refs/heads/master@{#427229}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-25 21:17:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 21:20:36]

Description was changed from

==========
Reland of gpu: Clarify sized texture format is available
(https://codereview.chromium.org/2117183006)

Reason for revert:
r425684 causes blank video of mediaStream playback in MacOSX, because MacOSX
relies on the hack, which the CL removed. This CL remains the hack only in
MacOSX.

BUG=535198, 657532

> Revert of gpu: Clarify sized texture format is available only if ES3 context
or immutable texture is supported (patchset #7 id:160001 of
https://codereview.chromium.org/2117183006/ )
>
> Reason for revert:
> Broke playing back recorded data as detailed
> in https://crbug.com/657532.  The bug has
> step-by-step notes on how to repro (see also #4
> in there).
>
> Locally reverting of this CL restores the functionality.
>
> Original issue's description:
> > gpu: Clarify the sized texture format is available only if ES3 context or
immutable texture is supported.
> >
> > This clarification makes it possible that gles2 decoder tracks true internal
format of immutable texture. So this CL removes internal_format hack in
GLES2DecoderImpl::TexStorageImpl()
> >
> > In addition, it makes CMAA skip redundant copy path because CMAA can know
true internal format.
> >
> > BUG=535198
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/730f8089f791fa31a3ee2a7f5059a1052b129d21
> > Cr-Commit-Position: refs/heads/master@{#425684}
>
>
TBR=dongseong.hwang@chromium.org,zmo@chromium.org,kbr@chromium.org,dongseong....
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=535198
>
> Review-Url: https://codereview.chromium.org/2443123004
> Cr-Commit-Position: refs/heads/master@{#427229}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reland of gpu: Clarify sized texture format is available
(https://codereview.chromium.org/2117183006)

Reason for revert:
r425684 causes blank video of mediaStream playback in MacOSX, because MacOSX
relies on the hack, which the CL removed. This CL remains the hack only in
MacOSX.

BUG=535198, 657532

> Revert of gpu: Clarify sized texture format is available only if ES3 context
or immutable texture is supported (patchset #7 id:160001 of
https://codereview.chromium.org/2117183006/ )
>
> Reason for revert:
> Broke playing back recorded data as detailed
> in https://crbug.com/657532.  The bug has
> step-by-step notes on how to repro (see also #4
> in there).
>
> Locally reverting of this CL restores the functionality.
>
> Original issue's description:
> > gpu: Clarify the sized texture format is available only if ES3 context or
immutable texture is supported.
> >
> > This clarification makes it possible that gles2 decoder tracks true internal
format of immutable texture. So this CL removes internal_format hack in
GLES2DecoderImpl::TexStorageImpl()
> >
> > In addition, it makes CMAA skip redundant copy path because CMAA can know
true internal format.
> >
> > BUG=535198
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/730f8089f791fa31a3ee2a7f5059a1052b129d21
> > Cr-Commit-Position: refs/heads/master@{#425684}
>
>
TBR=dongseong.hwang@chromium.org,zmo@chromium.org,kbr@chromium.org,dongseong....
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=535198
>
> Review-Url: https://codereview.chromium.org/2443123004
> Cr-Commit-Position: refs/heads/master@{#427229}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/460cac969e2e9ac38a2611be1a32db0361d88bfb
Cr-Commit-Position: refs/heads/master@{#427473}
==========

[commit-bot: I haz the power, 2016-10-25 21:20:37]

Patchset 2 (id:??) landed as
https://crrev.com/460cac969e2e9ac38a2611be1a32db0361d88bfb
Cr-Commit-Position: refs/heads/master@{#427473}