Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 2443123004: Revert of gpu: Clarify sized texture format is available only if ES3 context or immutable (Closed)

Created:
4 years, 1 month ago by mcasas
Modified:
4 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: Clarify sized texture format is available only if ES3 context or immutable texture is supported (patchset #7 id:160001 of https://codereview.chromium.org/2117183006/ ) Reason for revert: Broke playing back recorded data as detailed in https://crbug.com/657532. The bug has step-by-step notes on how to repro (see also #4 in there). Locally reverting of this CL restores the functionality. Original issue's description: > gpu: Clarify the sized texture format is available only if ES3 context or immutable texture is supported. > > This clarification makes it possible that gles2 decoder tracks true internal format of immutable texture. So this CL removes internal_format hack in GLES2DecoderImpl::TexStorageImpl() > > In addition, it makes CMAA skip redundant copy path because CMAA can know true internal format. > > BUG=535198 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/730f8089f791fa31a3ee2a7f5059a1052b129d21 > Cr-Commit-Position: refs/heads/master@{#425684} TBR=dongseong.hwang@chromium.org,zmo@chromium.org,kbr@chromium.org,dongseong.hwang@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=535198 Committed: https://crrev.com/8d269ce2fafd0ed7ee09507cc295f1cae12b01db Cr-Commit-Position: refs/heads/master@{#427229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -99 lines) Patch
M gpu/command_buffer/service/feature_info.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 8 chunks +10 lines, -21 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 4 chunks +18 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 chunk +2 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 7 chunks +19 lines, -46 lines 0 comments Download
M gpu/command_buffer/tests/gl_texture_storage_unittest.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mcasas
Created Revert of gpu: Clarify sized texture format is available only if ES3 context or ...
4 years, 1 month ago (2016-10-24 22:05:20 UTC) #2
dshwang
I submitted new CL to revert the CL in more narrow way. https://codereview.chromium.org/2452593002
4 years, 1 month ago (2016-10-25 12:40:24 UTC) #5
dshwang
4 years, 1 month ago (2016-10-25 12:41:43 UTC) #6
Message was sent while issue was closed.
On 2016/10/25 12:40:24, dshwang wrote:
> I submitted new CL to revert the CL in more narrow way.
> https://codereview.chromium.org/2452593002

ah, already reverted. ok, let me debug how to fix it.

Powered by Google App Engine
This is Rietveld 408576698