Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2448033002: Merge to M55: Revert of Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. (patchset #… (Closed)

Created:
4 years, 1 month ago by dmazzoni
Modified:
4 years, 1 month ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Merge to M55: Revert of Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. (patchset #2 id:20001 of https://codereview.chromium.org/2352213002/ ) Reason for revert: http://crbug.com/653330 This shortcut conflicts with some web pages, and there's no consensus on the proper fix (let web pages override, or switch to another key). Original issue's description: > Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. > > BUG=644758 > > Committed: https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e > Cr-Commit-Position: refs/heads/master@{#419884} TBR=jamescook@chromium.org,mpearson@chromium.org,suppasitaung6@gmail.com BUG=644758 Review-Url: https://codereview.chromium.org/2448663002 Cr-Commit-Position: refs/heads/master@{#427293} (cherry picked from commit bebe8961758cd40f8abeead4d96ab0d0a9f1628b) Committed: https://chromium.googlesource.com/chromium/src/+/e951a87b4b5f7f553e1f1dfb678bddce6665be12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M ash/common/accelerators/accelerator_controller.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M ash/common/accelerators/accelerator_table.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/accelerators/accelerator_table.cc View 5 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dmazzoni
4 years, 1 month ago (2016-10-25 07:12:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e951a87b4b5f7f553e1f1dfb678bddce6665be12.

Powered by Google App Engine
This is Rietveld 408576698