Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2448663002: Revert of Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. (Closed)

Created:
4 years, 1 month ago by dmazzoni
Modified:
4 years, 1 month ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. (patchset #2 id:20001 of https://codereview.chromium.org/2352213002/ ) Reason for revert: http://crbug.com/653330 This shortcut conflicts with some web pages, and there's no consensus on the proper fix (let web pages override, or switch to another key). Original issue's description: > Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. > > BUG=644758 > > Committed: https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e > Cr-Commit-Position: refs/heads/master@{#419884} TBR=jamescook@chromium.org,mpearson@chromium.org,suppasitaung6@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=644758 Committed: https://crrev.com/bebe8961758cd40f8abeead4d96ab0d0a9f1628b Cr-Commit-Position: refs/heads/master@{#427293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -27 lines) Patch
M ash/common/accelerators/accelerator_controller.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M ash/common/accelerators/accelerator_table.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/accelerators/accelerator_table.cc View 5 chunks +3 lines, -6 lines 0 comments Download
M tools/metrics/actions/actions.xml View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dmazzoni
Created Revert of Add Ctrl+Alt+H as global shortcut to toggle high contrast mode.
4 years, 1 month ago (2016-10-24 21:54:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448663002/1
4 years, 1 month ago (2016-10-24 21:55:01 UTC) #3
Mark P
These user actions have been rolled out to users. Please do not delete them. Mark ...
4 years, 1 month ago (2016-10-24 21:58:19 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/166708)
4 years, 1 month ago (2016-10-24 22:11:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448663002/1
4 years, 1 month ago (2016-10-25 06:43:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 06:49:12 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bebe8961758cd40f8abeead4d96ab0d0a9f1628b Cr-Commit-Position: refs/heads/master@{#427293}
4 years, 1 month ago (2016-10-25 06:51:50 UTC) #12
dmazzoni
4 years, 1 month ago (2016-10-25 06:58:48 UTC) #13
Message was sent while issue was closed.
On 2016/10/24 21:58:19, Mark P (sick) wrote:
> These user actions have been rolled out to users.  Please do not delete them. 
> Mark them as obsolete.
> 
> You can do this in a follow-up if you don't want to cancel this revert
> in-progress.
> 
> --mark

Sure, fixed here:
https://codereview.chromium.org/2445173003/

FYI, planning to re-land shortly, so it shouldn't actually be obsolete.

Powered by Google App Engine
This is Rietveld 408576698