Issue 24480005: modify polymer sample so that deploy works as is

Issue 24480005: modify polymer sample so that deploy works as is (Closed)

Created:
7 years, 2 months ago by keertip

Modified:
7 years, 2 months ago

Reviewers:
devoncarew

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

modify polymer sample so that deploy works as is dartbug.com/13590 R=devoncarew@google.com Committed: https://code.google.com/p/dart/source/detail?r=27958

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/build.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/clickcounter.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/webapp.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

devoncarew

lgtm https://codereview.chromium.org/24480005/diff/3001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/clickcounter.dart File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/clickcounter.dart (right): https://codereview.chromium.org/24480005/diff/3001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/clickcounter.dart#newcode1 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/clickcounter.dart:1: library clickcounter; nit: please add a black line ...

7 years, 2 months ago (2013-09-26 16:03:38 UTC) #2

keertip

https://codereview.chromium.org/24480005/diff/3001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/clickcounter.dart File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/clickcounter.dart (right): https://codereview.chromium.org/24480005/diff/3001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/clickcounter.dart#newcode1 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/clickcounter.dart:1: library clickcounter; On 2013/09/26 16:03:39, devoncarew wrote: > nit: ...

7 years, 2 months ago (2013-09-26 16:07:29 UTC) #3

keertip

7 years, 2 months ago (2013-09-26 16:15:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r27958 (presubmit successful).

Expand Messages | Collapse Messages