Issue 2447983002: Don't intercept Flash navigations when the current page is the Flash download page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2447983002: Don't intercept Flash navigations when the current page is the Flash download page. (Closed)

Created:
4 years, 1 month ago by raymes

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Don't intercept Flash navigations when the current page is the Flash download page. Currently, with HBD, if you navigate to https://get.adobe.com/flashplayer and click "Download", it will trigger the Run Flash prompt. We should ignore navigations if the source URL is the Flash download page itself. BUG=656062 Review-Url: https://codereview.chromium.org/2435933002 Cr-Commit-Position: refs/heads/master@{#427005} (cherry picked from commit 4b8d85c37e5a38e8db96c9c7eeb9cad16ee3dfcb) Committed: https://chromium.googlesource.com/chromium/src/+/a2d2699a1924d310b1c650a32f951887cfe47139

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	chrome/browser/plugins/flash_download_interception.cc	View		2 chunks	+13 lines, -2 lines	0 comments	Download
	M	chrome/browser/plugins/flash_download_interception_unittest.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

raymes

4 years, 1 month ago (2016-10-25 02:10:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a2d2699a1924d310b1c650a32f951887cfe47139.