Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2435933002: Don't intercept Flash navigations when the current page is the Flash download page. (Closed)

Created:
4 years, 2 months ago by raymes
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't intercept Flash navigations when the current page is the Flash download page. Currently, with HBD, if you navigate to https://get.adobe.com/flashplayer and click "Download", it will trigger the Run Flash prompt. We should ignore navigations if the source URL is the Flash download page itself. BUG=656062 Committed: https://crrev.com/4b8d85c37e5a38e8db96c9c7eeb9cad16ee3dfcb Cr-Commit-Position: refs/heads/master@{#427005}

Patch Set 1 #

Patch Set 2 : Don't intercept Flash navigations when the current page is the Flash download page. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M chrome/browser/plugins/flash_download_interception.cc View 1 2 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/plugins/flash_download_interception_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
raymes
4 years, 2 months ago (2016-10-20 04:39:00 UTC) #3
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-10-20 12:50:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435933002/20001
4 years, 2 months ago (2016-10-23 22:46:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-23 23:29:49 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-23 23:32:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b8d85c37e5a38e8db96c9c7eeb9cad16ee3dfcb
Cr-Commit-Position: refs/heads/master@{#427005}

Powered by Google App Engine
This is Rietveld 408576698