Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2447953002: [Payments] Add metrics for the new payer name contact info. (Closed)

Created:
4 years, 1 month ago by sebsg
Modified:
4 years, 1 month ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Add metrics for the new payer name contact info. BUG=658418 Committed: https://crrev.com/21f34b2ff2b4903a3ed4149cad44b2867076d864 Cr-Commit-Position: refs/heads/master@{#427360}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits #

Messages

Total messages: 21 (14 generated)
sebsg
Hi Rouslan, PTAL?
4 years, 1 month ago (2016-10-25 13:08:18 UTC) #7
please use gerrit instead
lgtm % nit https://codereview.chromium.org/2447953002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java (right): https://codereview.chromium.org/2447953002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java#newcode63 chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java:63: * shipping address results in the ...
4 years, 1 month ago (2016-10-25 13:12:42 UTC) #8
sebsg
Hi Robert, could you please review histograms.xml? Thanks!
4 years, 1 month ago (2016-10-25 13:21:17 UTC) #12
rkaplow
lgtm
4 years, 1 month ago (2016-10-25 15:27:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447953002/40001
4 years, 1 month ago (2016-10-25 15:28:33 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-10-25 15:33:29 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 15:43:57 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21f34b2ff2b4903a3ed4149cad44b2867076d864
Cr-Commit-Position: refs/heads/master@{#427360}

Powered by Google App Engine
This is Rietveld 408576698