chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java - Issue 2447953002: [Payments] Add metrics for the new payer name contact info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java

Issue 2447953002: [Payments] Add metrics for the new payer name contact info. (Closed)

Patch Set: Nits Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_sources.gni ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java

index 6e05b1f1b3e11f077371e2784f18a493285ef33f..b53918cc1a706ad57cfbd211ed524c8bb7ac0d47 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java

@@ -59,8 +59,8 @@ public class PaymentRequestContactDetailsAndFreeShippingTest extends PaymentRequ

}

/**

- * Test that starting a payment request that requires an email address, a phone number and a

- * shipping address results in the appropriate metric being logged in the

+ * Test that starting a payment request that requires an email address, a phone number a name

+ * and a shipping address results in the appropriate metric being logged in the

* PaymentRequest.RequestedInformation histogram.

@MediumTest

@@ -74,7 +74,8 @@ public class PaymentRequestContactDetailsAndFreeShippingTest extends PaymentRequ

for (int i = 0; i < PaymentRequestMetrics.REQUESTED_INFORMATION_MAX; ++i) {

assertEquals((i == (PaymentRequestMetrics.REQUESTED_INFORMATION_EMAIL

| PaymentRequestMetrics.REQUESTED_INFORMATION_PHONE

- | PaymentRequestMetrics.REQUESTED_INFORMATION_SHIPPING) ? 1 : 0),

+ | PaymentRequestMetrics.REQUESTED_INFORMATION_SHIPPING

+ | PaymentRequestMetrics.REQUESTED_INFORMATION_NAME) ? 1 : 0),

RecordHistogram.getHistogramValueCountForTesting(

"PaymentRequest.RequestedInformation", i));

}