Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2447813002: Strengthen the rules when the Credential Manager API is disabled. (Closed)

Created:
4 years, 1 month ago by vasilii
Modified:
4 years, 1 month ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, jam, gcasto+watchlist_chromium.org, darin-cc_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Strengthen the rules when the Credential Manager API is disabled. The CL just removes the custom conditions in CredentialManagerImpl and reuses the methods used for autofill. BUG=658732 Committed: https://crrev.com/9fd65516a78385714d4d6740134b4a51c7eb5bab Cr-Commit-Position: refs/heads/master@{#427327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M components/password_manager/content/browser/credential_manager_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/password_manager/content/browser/credential_manager_impl.cc View 4 chunks +3 lines, -9 lines 0 comments Download
M components/password_manager/content/browser/credential_manager_impl_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
vasilii
Hi Vaclav, please review.
4 years, 1 month ago (2016-10-24 17:15:01 UTC) #4
vabr (Chromium)
LGTM, thanks for the improvement! Sorry for the delay, today has been more interesting than ...
4 years, 1 month ago (2016-10-25 12:27:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447813002/1
4 years, 1 month ago (2016-10-25 12:28:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 12:32:51 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 12:34:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fd65516a78385714d4d6740134b4a51c7eb5bab
Cr-Commit-Position: refs/heads/master@{#427327}

Powered by Google App Engine
This is Rietveld 408576698