Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: components/password_manager/content/browser/credential_manager_impl.h

Issue 2447813002: Strengthen the rules when the Credential Manager API is disabled. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/password_manager/content/browser/credential_manager_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_I MPL_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_I MPL_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_I MPL_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_I MPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 const std::vector<GURL>& federations, 90 const std::vector<GURL>& federations,
91 const std::vector<std::string>& android_realms); 91 const std::vector<std::string>& android_realms);
92 92
93 // Schedules a CredentialManagerPendingRequireUserMediationTask after the 93 // Schedules a CredentialManagerPendingRequireUserMediationTask after the
94 // AffiliationMatchHelper grabs a list of realms related to the current 94 // AffiliationMatchHelper grabs a list of realms related to the current
95 // web origin. 95 // web origin.
96 void ScheduleRequireMediationTask( 96 void ScheduleRequireMediationTask(
97 const RequireUserMediationCallback& callback, 97 const RequireUserMediationCallback& callback,
98 const std::vector<std::string>& android_realms); 98 const std::vector<std::string>& android_realms);
99 99
100 // Returns true iff it's OK to update credentials in the password store.
101 bool IsUpdatingCredentialAllowed() const;
102
103 PasswordManagerClient* client_; 100 PasswordManagerClient* client_;
104 std::unique_ptr<CredentialManagerPasswordFormManager> form_manager_; 101 std::unique_ptr<CredentialManagerPasswordFormManager> form_manager_;
105 102
106 // Set to false to disable automatic signing in. 103 // Set to false to disable automatic signing in.
107 BooleanPrefMember auto_signin_enabled_; 104 BooleanPrefMember auto_signin_enabled_;
108 105
109 // When 'OnRequestCredential' is called, it in turn calls out to the 106 // When 'OnRequestCredential' is called, it in turn calls out to the
110 // PasswordStore; we push enough data into Pending*Task objects so that 107 // PasswordStore; we push enough data into Pending*Task objects so that
111 // they can properly respond to the request once the PasswordStore gives 108 // they can properly respond to the request once the PasswordStore gives
112 // us data. 109 // us data.
113 std::unique_ptr<CredentialManagerPendingRequestTask> pending_request_; 110 std::unique_ptr<CredentialManagerPendingRequestTask> pending_request_;
114 std::unique_ptr<CredentialManagerPendingRequireUserMediationTask> 111 std::unique_ptr<CredentialManagerPendingRequireUserMediationTask>
115 pending_require_user_mediation_; 112 pending_require_user_mediation_;
116 113
117 mojo::BindingSet<mojom::CredentialManager> bindings_; 114 mojo::BindingSet<mojom::CredentialManager> bindings_;
118 115
119 base::WeakPtrFactory<CredentialManagerImpl> weak_factory_; 116 base::WeakPtrFactory<CredentialManagerImpl> weak_factory_;
120 117
121 DISALLOW_COPY_AND_ASSIGN(CredentialManagerImpl); 118 DISALLOW_COPY_AND_ASSIGN(CredentialManagerImpl);
122 }; 119 };
123 120
124 } // namespace password_manager 121 } // namespace password_manager
125 122
126 #endif // COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGE R_IMPL_H_ 123 #endif // COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGE R_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | components/password_manager/content/browser/credential_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698