Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2447653002: INPUT element: Do not dispatch events in detachLayoutTree(). (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years, 1 month ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT element: Do not dispatch events in detachLayoutTree(). When a color chooser is closed, we dispatches a 'change' event asynchronously. Some tests need to be updated due to this behavior change. BUG=658535 Committed: https://crrev.com/fbe37c7239e4a6e75f12c0d35e60987a6aa75ee0 Cr-Commit-Position: refs/heads/master@{#427286}

Patch Set 1 #

Messages

Total messages: 23 (18 generated)
tkent
keishi, would you review this please?
4 years, 1 month ago (2016-10-25 04:57:37 UTC) #17
keishi
LGTM
4 years, 1 month ago (2016-10-25 05:32:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447653002/40001
4 years, 1 month ago (2016-10-25 06:16:31 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 1 month ago (2016-10-25 06:20:35 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 06:22:58 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbe37c7239e4a6e75f12c0d35e60987a6aa75ee0
Cr-Commit-Position: refs/heads/master@{#427286}

Powered by Google App Engine
This is Rietveld 408576698