third_party/WebKit/Source/core/html/forms/ColorInputType.cpp - Issue 2447653002: INPUT element: Do not dispatch events in detachLayoutTree().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

Issue 2447653002: INPUT element: Do not dispatch events in detachLayoutTree(). (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

index d7d006cb590a1be3c3a4963437892d8276c9b056..4848a74b8cdf1aa851fb2e77e413cd262ac85d18 100644

--- a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

@@ -202,9 +202,8 @@ void ColorInputType::didChooseColor(const Color& color) {

}

void ColorInputType::didEndChooser() {

- EventQueueScope scope;

if (LayoutTheme::theme().isModalColorChooser())

- element().dispatchFormControlChangeEvent();

+ element().enqueueChangeEvent();

m_chooser.clear();

}