Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7654)

Unified Diff: chrome/common/extensions/api/extension_action/action_info.cc

Issue 2447553003: More pre-MD odds and ends. (Closed)
Patch Set: self review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_action/action_info.cc
diff --git a/chrome/common/extensions/api/extension_action/action_info.cc b/chrome/common/extensions/api/extension_action/action_info.cc
index fb14e9f1958b145213f0ab98e43378e61e886d54..a17e5c008a7501cdca64c74dea76a6105a797da8 100644
--- a/chrome/common/extensions/api/extension_action/action_info.cc
+++ b/chrome/common/extensions/api/extension_action/action_info.cc
@@ -73,7 +73,9 @@ std::unique_ptr<ActionInfo> ActionInfo::Load(const Extension* extension,
*error = base::ASCIIToUTF16(errors::kInvalidPageActionIconPath);
return std::unique_ptr<ActionInfo>();
}
- result->default_icon.Add(extension_misc::EXTENSION_ICON_ACTION, path);
+ // 19 is the old size for extension icons (the size that was in use at the
+ // time of kPageActionIcons).
Peter Kasting 2016/10/26 03:28:47 Nit: Shorter: "Extension icons were 19 DIP when kP
Evan Stade 2016/11/02 00:41:13 Done.
+ result->default_icon.Add(19, path);
}
std::string id;

Powered by Google App Engine
This is Rietveld 408576698