chrome/browser/ui/views/location_bar/page_action_image_view_interactive_uitest.cc - Issue 2447553003: More pre-MD odds and ends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_action_image_view_interactive_uitest.cc

Issue 2447553003: More pre-MD odds and ends. (Closed)

Patch Set: self review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/location_bar/page_action_image_view.cc ('K') | « chrome/browser/ui/views/location_bar/page_action_image_view.cc ('k') | chrome/common/chrome_constants.h » ('j') | chrome/common/extensions/api/extension_action/action_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/page_action_image_view_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/location_bar/page_action_image_view_interactive_uitest.cc b/chrome/browser/ui/views/location_bar/page_action_image_view_interactive_uitest.cc

index 692f52b3136290b29949dfc70d507a9464e4c51a..97685a770c3dafac67a5ce1c55c4aff5188df490 100644

--- a/chrome/browser/ui/views/location_bar/page_action_image_view_interactive_uitest.cc

+++ b/chrome/browser/ui/views/location_bar/page_action_image_view_interactive_uitest.cc

@@ -124,8 +124,8 @@ IN_PROC_BROWSER_TEST_F(PageActionImageViewInteractiveUITest,

// We need to resize the expected icon to be the size of the page action

// button for comparison purposes.

- const gfx::Size size(extension_misc::EXTENSION_ICON_ACTION,

- extension_misc::EXTENSION_ICON_ACTION);

+ const gfx::Size size(extension_misc::EXTENSION_ICON_BITTY,

+ extension_misc::EXTENSION_ICON_BITTY);

Peter Kasting 2016/10/26 03:28:47 Shouldn't this also use ExtensionAction::ActionIco

Evan Stade 2016/11/02 00:41:13 Done.

gfx::ImageSkia bg(new BlankImageSource(size), size);

expected_icon =

gfx::ImageSkiaOperations::CreateSuperimposedImage(bg, expected_icon);