More pre-MD odds and ends.

chrome/browser/ui/views/location_bar/page_action_image_view.cc

Index: chrome/browser/ui/views/location_bar/page_action_image_view.cc
diff --git a/chrome/browser/ui/views/location_bar/page_action_image_view.cc b/chrome/browser/ui/views/location_bar/page_action_image_view.cc
index 8660f5a9170cbcbe1256d464d02b7fe3abb625d5..4b1a7edcb0bc54c64ed0388fe47d839c29c95efe 100644
--- a/chrome/browser/ui/views/location_bar/page_action_image_view.cc
+++ b/chrome/browser/ui/views/location_bar/page_action_image_view.cc
@@ -105,8 +105,8 @@ void PageActionImageView::UpdateVisibility(content::WebContents* contents) {
   SetTooltipText(base::UTF8ToUTF16(tooltip_));
 
   // Set the image.
-  gfx::Size size(extension_misc::EXTENSION_ICON_ACTION,
-                 extension_misc::EXTENSION_ICON_ACTION);
+  gfx::Size size(ExtensionAction::ActionIconSize(),
+                 ExtensionAction::ActionIconSize());

[Peter Kasting, 2016/10/26 03:28:47]

Nit: I suggest using a temp for this value, since the name implies the call is
expensive.

(Separately possible: Change this function to a cheap inlined getter, maybe make
constexpr as well)

[Evan Stade, 2016/11/02 00:41:13]

How do you feel about creating a ctor for gfx::Size that has one param and
creates a square? It seems to me that this comes up a lot. (Would be a separate
CL.)

[Peter Kasting, 2016/11/02 00:47:44]

I'd ask danakj this.

It does come up a lot, so I'm weakly supportive, although I dunno if it's a
little unintuitive (then again, what else would it mean but "make a square"?).

   gfx::Image icon = view_controller_->GetIcon(contents, size);
   if (!icon.IsEmpty())
     SetImage(*icon.ToImageSkia());