chrome/android/java/strings/android_chrome_strings.grd - Issue 2447413006: [Offline pages] Introducing Open online button in OIB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 2447413006: [Offline pages] Introducing Open online button in OIB (Closed)

Patch Set: Rebasing Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/strings/android_chrome_strings.grd

diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd

index bdcf0d61140388384ca01fc08400ec52a8c16cca..f8fbec3abc0b3287ed79128b6155544371e6448e 100644

--- a/chrome/android/java/strings/android_chrome_strings.grd

+++ b/chrome/android/java/strings/android_chrome_strings.grd

@@ -1617,6 +1617,9 @@ To obtain new licenses, connect to the internet and play your downloaded content

This content is from <ph name="DOMAIN_NAME">%1$s<ex>google.com</ex></ph>, delivered by Google.

</message>

+ <message name="IDS_PAGE_INFO_OPEN_ONLINE_BUTTON" desc="Text in the button that opens an online version of the offline website displayed in the tab.">

+ Open Online

Ted C 2016/11/01 16:58:33 Out of scope of this change, but I find this wordi

fgorski 2016/11/01 19:31:38 Acknowledged.

+ </message>