[Offline pages] Introducing Open online button in OIB

[Offline pages] Introducing Open online button in OIB

Changes WebsiteSettingsPopup
* Adds a button to "Open online" with click handler
* Passes a tab to WSP to be able to handle open online click

BUG=656804
Committed: https://crrev.com/3895e09ff868cf3507b95c53a73618a8af69369e
Cr-Commit-Position: refs/heads/master@{#429095}

[fgorski, 2016-10-31 16:55:42]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 16:55:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 17:25:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 17:25:04]

Dry run: This issue passed the CQ dry run.

[fgorski, 2016-10-31 20:18:03]

fgorski@chromium.org changed reviewers:
+ tedchoc@chromium.org

[fgorski, 2016-10-31 20:18:04]

Ted, PTAL,

DD: go/paquete-oib-open-online-dd

[dewittj, 2016-10-31 20:27:38]

drive-by!

https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java:841:
OfflinePageUtils.reload(mTab);
I know this is addressed in the design doc, but might be nice to have a comment
explaining that the open online button might reopen the offline page in the case
of bad/too slow network.

[Ted C, 2016-11-01 16:58:33]

lgtm

https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:1621: Open Online
Out of scope of this change, but I find this wording to be really, really weird.
 I don't have a good suggestion but I've read this a few times now and each time
it still looks off.

[fgorski, 2016-11-01 19:31:09]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[fgorski, 2016-11-01 19:31:39]

minor updates based on comments.

https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java:841:
OfflinePageUtils.reload(mTab);
On 2016/10/31 20:27:37, dewittj wrote:
> I know this is addressed in the design doc, but might be nice to have a
comment
> explaining that the open online button might reopen the offline page in the
case
> of bad/too slow network.

Done.

https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:1621: Open Online
On 2016/11/01 16:58:33, Ted C wrote:
> Out of scope of this change, but I find this wording to be really, really
weird.
>  I don't have a good suggestion but I've read this a few times now and each
time
> it still looks off.

Acknowledged.

[commit-bot: I haz the power, 2016-11-01 19:31:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-11-01 19:39:53]

The CQ bit was unchecked by fgorski@chromium.org

[fgorski, 2016-11-01 19:39:55]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-11-01 19:39:55]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2447413006/#ps40001
(title: "Addressing feedback")

[commit-bot: I haz the power, 2016-11-01 19:40:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-11-01 19:51:23]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-11-01 19:51:23]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2447413006/#ps60001
(title: "Fixing the label to capitalize all words again")

[commit-bot: I haz the power, 2016-11-01 19:51:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 20:38:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-01 20:45:33]

Description was changed from

==========
[Offline pages] Introducing Open online button in OIB

Changes WebsiteSettingsPopup
* Adds a button to "Open online" with click handler
* Passes a tab to WSP to be able to handle open online click

BUG=656804
==========

to

==========
[Offline pages] Introducing Open online button in OIB

Changes WebsiteSettingsPopup
* Adds a button to "Open online" with click handler
* Passes a tab to WSP to be able to handle open online click

BUG=656804

Committed: https://crrev.com/3895e09ff868cf3507b95c53a73618a8af69369e
Cr-Commit-Position: refs/heads/master@{#429095}
==========

[commit-bot: I haz the power, 2016-11-01 20:45:34]

Patchset 4 (id:??) landed as
https://crrev.com/3895e09ff868cf3507b95c53a73618a8af69369e
Cr-Commit-Position: refs/heads/master@{#429095}