Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 2447413006: [Offline pages] Introducing Open online button in OIB (Closed)

Created:
4 years, 1 month ago by fgorski
Modified:
4 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Introducing Open online button in OIB Changes WebsiteSettingsPopup * Adds a button to "Open online" with click handler * Passes a tab to WSP to be able to handle open online click BUG=656804 Committed: https://crrev.com/3895e09ff868cf3507b95c53a73618a8af69369e Cr-Commit-Position: refs/heads/master@{#429095}

Patch Set 1 #

Patch Set 2 : Rebasing #

Total comments: 4

Patch Set 3 : Addressing feedback #

Patch Set 4 : Fixing the label to capitalize all words again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -14 lines) Patch
M chrome/android/java/res/layout/website_settings.xml View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 1 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java View 1 2 8 chunks +28 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
fgorski
Ted, PTAL, DD: go/paquete-oib-open-online-dd
4 years, 1 month ago (2016-10-31 20:18:04 UTC) #6
dewittj
drive-by! https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java File chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java (right): https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java#newcode841 chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java:841: OfflinePageUtils.reload(mTab); I know this is addressed in the ...
4 years, 1 month ago (2016-10-31 20:27:38 UTC) #7
Ted C
lgtm https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/strings/android_chrome_strings.grd#newcode1621 chrome/android/java/strings/android_chrome_strings.grd:1621: Open Online Out of scope of this change, ...
4 years, 1 month ago (2016-11-01 16:58:33 UTC) #8
fgorski
minor updates based on comments. https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java File chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java (right): https://codereview.chromium.org/2447413006/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java#newcode841 chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java:841: OfflinePageUtils.reload(mTab); On 2016/10/31 20:27:37, ...
4 years, 1 month ago (2016-11-01 19:31:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447413006/40001
4 years, 1 month ago (2016-11-01 19:40:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447413006/60001
4 years, 1 month ago (2016-11-01 19:51:56 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-01 20:38:30 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 20:45:34 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3895e09ff868cf3507b95c53a73618a8af69369e
Cr-Commit-Position: refs/heads/master@{#429095}

Powered by Google App Engine
This is Rietveld 408576698