Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2447403002: Revert of Generate Signed Distance Field directly from vector path (Closed)

Created:
4 years, 1 month ago by bsalomon
Modified:
4 years, 1 month ago
CC:
reviews_skia.org, developer_arm.com
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Generate Signed Distance Field directly from vector path (patchset #19 id:360001 of https://codereview.chromium.org/1643143002/ ) Reason for revert: Chrome crash Original issue's description: > Generate Signed Distance Field directly from vector path > > Add SkGenerateDistanceFieldFromPath API to generate signed distance field directly from SkPath. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643143002 > > Committed: https://skia.googlesource.com/skia/+/4de97a64e8829323a7070b623411d9f9ddb0cd0f > Committed: https://skia.googlesource.com/skia/+/e8f0a7b986f1e5583c9bc162efcdd92fd6430549 > Committed: https://skia.googlesource.com/skia/+/67c7c81a82b6351e9fbbf235084d7120162d9268 TBR=jvanverth@google.com,mtklein@google.com,wasim.abbas@arm.com,caryclark@google.com,reed@google.com,joel.liang@arm.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f93f5151612a4b1adfe1dad0490bd1c01ee73598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -902 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D src/gpu/GrDistanceFieldGenFromVector.h View 1 chunk +0 lines, -35 lines 0 comments Download
D src/gpu/GrDistanceFieldGenFromVector.cpp View 1 chunk +0 lines, -827 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 4 chunks +29 lines, -27 lines 0 comments Download
M src/gpu/text/GrBatchFontCache.cpp View 2 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bsalomon
Created Revert of Generate Signed Distance Field directly from vector path
4 years, 1 month ago (2016-10-26 14:39:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447403002/1
4 years, 1 month ago (2016-10-26 14:40:01 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 15:00:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f93f5151612a4b1adfe1dad0490bd1c01ee73598

Powered by Google App Engine
This is Rietveld 408576698