Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 2447213002: Revert of Revert "Simplify handling of text input types in RenderWidget." (Closed)

Created:
4 years, 1 month ago by dglazkov
Modified:
4 years, 1 month ago
Reviewers:
esprehn
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Simplify handling of text input types in RenderWidget." (patchset #1 id:1 of https://codereview.chromium.org/2453503002/ ) Reason for revert: Bad diff editing on my part. Original issue's description: > Revert "Simplify handling of text input types in RenderWidget." > > This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df, > because it broke IME. > > BUG=653958 > TBR=esprehn > > Review-Url: https://codereview.chromium.org/2442323004 > Cr-Commit-Position: refs/heads/master@{#427396} > (cherry picked from commit 97b6c2bd1278f651b9b30e22685ede87f761a9ca) > > Committed: https://chromium.googlesource.com/chromium/src/+/cddb25425a67f01e75126631a0e03a6b86b1fa3a TBR=esprehn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -22 lines) Patch
M content/renderer/render_widget.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_widget.cc View 6 chunks +43 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dglazkov
Created Revert of Revert "Simplify handling of text input types in RenderWidget."
4 years, 1 month ago (2016-10-25 19:47:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447213002/1
4 years, 1 month ago (2016-10-25 19:48:12 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 19:50:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698