Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2447013004: [wasm] Remove the "Wasm" object. (Closed)

Created:
4 years, 1 month ago by titzer
Modified:
4 years, 1 month ago
Reviewers:
bradnelson, rossberg
CC:
v8-reviews_googlegroups.com, ahaas
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove the "Wasm" object. BUG=chromium:575167, v8:5507 R=rossberg@chromium.org,bradnelson@chromium.org CC=ahaas@chromium.org Committed: https://crrev.com/24d38be132d66783406e8f18595218d47ef1edda Cr-Commit-Position: refs/heads/master@{#40601}

Patch Set 1 #

Patch Set 2 : fix regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -193 lines) Patch
M src/wasm/wasm-js.cc View 2 chunks +2 lines, -135 lines 0 comments Download
M test/mjsunit/regress/regress-575364.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 3 chunks +48 lines, -44 lines 0 comments Download
M test/mjsunit/wasm/wasm-object-api.js View 1 chunk +3 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
titzer
PTAL; depends on 0xD
4 years, 1 month ago (2016-10-26 12:31:04 UTC) #7
bradnelson
lgtm
4 years, 1 month ago (2016-10-26 16:15:30 UTC) #10
rossberg
Let the sucker die. lgtm
4 years, 1 month ago (2016-10-26 16:26:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447013004/20001
4 years, 1 month ago (2016-10-26 16:57:06 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 16:58:47 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:14:34 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24d38be132d66783406e8f18595218d47ef1edda
Cr-Commit-Position: refs/heads/master@{#40601}

Powered by Google App Engine
This is Rietveld 408576698