[wasm] Binary 0xD: update encoding of opcodes, types, and add immediates.

[wasm] Binary 0xD: update encoding of opcodes, types, and add immediates.

R=ahaas@chromium.org,rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org
BUG=chromium:575167, chromium:659591
Committed: https://crrev.com/3f207617d7141cfc3a7051a243f8bbfb98c879c7
Cr-Commit-Position: refs/heads/master@{#40600}

[titzer, 2016-10-21 11:21:31]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 11:21:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 11:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 11:40:13]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[rossberg, 2016-10-21 11:41:23]

LGTM modulo wrong ordering of comparisons

https://codereview.chromium.org/2440953002/diff/1/src/wasm/wasm-opcodes.h
File src/wasm/wasm-opcodes.h (right):

https://codereview.chromium.org/2440953002/diff/1/src/wasm/wasm-opcodes.h#new...
src/wasm/wasm-opcodes.h:122: V(I32LtS, 0x48, i_ii)           \
The order of comparisons has changed such that _S and _U versions are always
adjacent.

https://codereview.chromium.org/2440953002/diff/1/src/wasm/wasm-opcodes.h#new...
src/wasm/wasm-opcodes.h:133: V(I64LtS, 0x53, i_ll)           \
Same here.

https://codereview.chromium.org/2440953002/diff/1/src/wasm/wasm-opcodes.h#new...
src/wasm/wasm-opcodes.h:144: V(F32Le, 0x5e, i_ff)            \
Switch this and the next one.

https://codereview.chromium.org/2440953002/diff/1/src/wasm/wasm-opcodes.h#new...
src/wasm/wasm-opcodes.h:150: V(F64Le, 0x64, i_dd)            \
Same here.

https://codereview.chromium.org/2440953002/diff/1/test/mjsunit/wasm/wasm-cons...
File test/mjsunit/wasm/wasm-constants.js (right):

https://codereview.chromium.org/2440953002/diff/1/test/mjsunit/wasm/wasm-cons...
test/mjsunit/wasm/wasm-constants.js:198: let kExprI32LtS = 0x48;
Same order mismatch for comparisons in this file.

[ahaas, 2016-10-21 12:24:18]

lgtm

[titzer, 2016-10-21 12:28:20]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 12:28:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-10-21 12:29:39]

Updated order of comparisons. PTAL

https://codereview.chromium.org/2440953002/diff/1/src/wasm/wasm-opcodes.h
File src/wasm/wasm-opcodes.h (right):

https://codereview.chromium.org/2440953002/diff/1/src/wasm/wasm-opcodes.h#new...
src/wasm/wasm-opcodes.h:122: V(I32LtS, 0x48, i_ii)           \
On 2016/10/21 11:41:23, rossberg wrote:
> The order of comparisons has changed such that _S and _U versions are always
> adjacent.

Done.

https://codereview.chromium.org/2440953002/diff/1/src/wasm/wasm-opcodes.h#new...
src/wasm/wasm-opcodes.h:133: V(I64LtS, 0x53, i_ll)           \
On 2016/10/21 11:41:23, rossberg wrote:
> Same here.

Done.

https://codereview.chromium.org/2440953002/diff/1/src/wasm/wasm-opcodes.h#new...
src/wasm/wasm-opcodes.h:144: V(F32Le, 0x5e, i_ff)            \
On 2016/10/21 11:41:23, rossberg wrote:
> Switch this and the next one.

Done.

https://codereview.chromium.org/2440953002/diff/1/src/wasm/wasm-opcodes.h#new...
src/wasm/wasm-opcodes.h:150: V(F64Le, 0x64, i_dd)            \
On 2016/10/21 11:41:23, rossberg wrote:
> Same here.

Done.

https://codereview.chromium.org/2440953002/diff/1/test/mjsunit/wasm/wasm-cons...
File test/mjsunit/wasm/wasm-constants.js (right):

https://codereview.chromium.org/2440953002/diff/1/test/mjsunit/wasm/wasm-cons...
test/mjsunit/wasm/wasm-constants.js:198: let kExprI32LtS = 0x48;
On 2016/10/21 11:41:23, rossberg wrote:
> Same order mismatch for comparisons in this file.

Done.

[rossberg, 2016-10-21 12:33:12]

LGTM

[commit-bot: I haz the power, 2016-10-21 12:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 12:46:40]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/16557)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[titzer, 2016-10-21 13:58:31]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 13:58:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 14:24:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 14:24:34]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2016-10-21 18:54:47]

lgtm

https://codereview.chromium.org/2440953002/diff/40001/src/wasm/wasm-opcodes.h
File src/wasm/wasm-opcodes.h (right):

https://codereview.chromium.org/2440953002/diff/40001/src/wasm/wasm-opcodes.h...
src/wasm/wasm-opcodes.h:19: kLocalI32 = 0x7f,
Might be good to comment these are -1 signed-LEB?

[titzer, 2016-10-24 17:36:26]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 17:36:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 18:04:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 18:04:11]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-10-26 10:56:42]

Description was changed from

==========
[wasm] Binary 0xD: update encoding of opcodes, types, and add immediates.

R=ahaas@chromium.org,rossberg@chromium.org,binji@chromium.org,bradnelson@chro...
BUG=chromium:575167
==========

to

==========
[wasm] Binary 0xD: update encoding of opcodes, types, and add immediates.

R=ahaas@chromium.org,rossberg@chromium.org,binji@chromium.org,bradnelson@chro...
BUG=chromium:575167, chromium:659591
==========

[titzer, 2016-10-26 14:30:07]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 14:30:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 14:50:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 14:50:07]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

[titzer, 2016-10-26 15:06:26]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 15:06:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 15:21:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 15:21:03]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/16895)

[titzer, 2016-10-26 15:50:48]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 15:50:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Derek Schuff, 2016-10-26 16:15:29]

In src/wasm/module-decoder.cc:316, the decoder for table imports still expects
an element type of 0x20 instead of 0x70.
With that change, it looks like the output of Binaryen's 0xd branch is
compatible with v8.

[commit-bot: I haz the power, 2016-10-26 16:19:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:19:32]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-10-26 16:26:13]

On 2016/10/26 16:15:29, Derek Schuff wrote:
> In src/wasm/module-decoder.cc:316, the decoder for table imports still expects
> an element type of 0x20 instead of 0x70.
> With that change, it looks like the output of Binaryen's 0xd branch is
> compatible with v8.

Ah, nice catch. Done.

[titzer, 2016-10-26 16:26:31]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 16:26:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:52:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:52:45]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-10-26 16:53:54]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-10-26 16:53:54]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org,
rossberg@chromium.org, bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/2440953002/#ps160001
(title: "Fix imported table kind.")

[commit-bot: I haz the power, 2016-10-26 16:54:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:56:11]

Description was changed from

==========
[wasm] Binary 0xD: update encoding of opcodes, types, and add immediates.

R=ahaas@chromium.org,rossberg@chromium.org,binji@chromium.org,bradnelson@chro...
BUG=chromium:575167, chromium:659591
==========

to

==========
[wasm] Binary 0xD: update encoding of opcodes, types, and add immediates.

R=ahaas@chromium.org,rossberg@chromium.org,binji@chromium.org,bradnelson@chro...
BUG=chromium:575167, chromium:659591
==========

[commit-bot: I haz the power, 2016-10-26 16:56:13]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-11-17 22:14:30]

Description was changed from

==========
[wasm] Binary 0xD: update encoding of opcodes, types, and add immediates.

R=ahaas@chromium.org,rossberg@chromium.org,binji@chromium.org,bradnelson@chro...
BUG=chromium:575167, chromium:659591
==========

to

==========
[wasm] Binary 0xD: update encoding of opcodes, types, and add immediates.

R=ahaas@chromium.org,rossberg@chromium.org,binji@chromium.org,bradnelson@chro...
BUG=chromium:575167, chromium:659591

Committed: https://crrev.com/3f207617d7141cfc3a7051a243f8bbfb98c879c7
Cr-Commit-Position: refs/heads/master@{#40600}
==========

[commit-bot: I haz the power, 2016-11-17 22:14:32]

Patchset 9 (id:??) landed as
https://crrev.com/3f207617d7141cfc3a7051a243f8bbfb98c879c7
Cr-Commit-Position: refs/heads/master@{#40600}