Custom Elements: Lookup custom element definition algorithm

https://html.spec.whatwg.org/multipage/scripting.html#look-up-a-custom-element-definition

Steps 1-3 already implemented in:
    /core/html/parser/HTMLConstructionSite.cpp

Steps 4-6 made a little faster in CustomElementRegistry.cpp

Unit tests added for custom element definition look up.

Replaced uses of definitionForName with definitionFor.
    CustomElementRegistry.cpp
    CustomElement.cpp
There are other calls to definitionForName, but those are fine according to spec.

I'll do another patch to use the 'is' attribute in definitionFor. Right now it's using the localName twice.

BUG=648828
Committed: https://crrev.com/24d712bfdf73e44b31fa9d058ba37e035cbe58ad
Cr-Commit-Position: refs/heads/master@{#430498}

[yurak, 2016-10-27 02:59:17]

Description was changed from

==========
Custom Elements: Lookup custom element definition algorithm

BUG=648828
==========

to

==========
https://html.spec.whatwg.org/multipage/scripting.html#look-up-a-custom-elemen...

Steps 1-3 already implemented in:
    /core/html/parser/HTMLConstructionSite.cpp

Steps 4-6 completed in CustomElementRegistry.cpp

Unit tests added, some of it depends on patch with custom element define
algorithm.

BUG=648828
==========

[yurak, 2016-10-27 02:59:17]

yurak@google.com changed reviewers:
+ dominicc@chromium.org, tkent@chromium.org

[yurak, 2016-10-27 03:03:19]

PTL! :)

[dominicc (has gone to gerrit), 2016-10-27 04:33:13]

dominicc@chromium.org changed reviewers:
+ kojii@chromium.org
- tkent@chromium.org

[dominicc (has gone to gerrit), 2016-10-27 04:33:14]

Comments inline.

Might make sense to have prose instead of a spec link as the first line of the
patch description.

https://codereview.chromium.org/2446903008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp
(right):

https://codereview.chromium.org/2446903008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp:201: // 4.
If there is a definition in registry with name equal to localName and
Try to write this with only one lookup with definitionForName. Note: localName
== name for autonomous custom elements.

https://codereview.chromium.org/2446903008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/custom/CustomElementTest.cpp (right):

https://codereview.chromium.org/2446903008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/custom/CustomElementTest.cpp:232:
TEST(CustomElementTest, CreateElement_LookupCustomElement) {
Could we put this in CustomElementRegistryTest? definitionFor is a
CustomElementRegistry method.

https://codereview.chromium.org/2446903008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/custom/CustomElementTest.cpp:249: // lookup
defined autonomous custom element
lookup -> look up

https://codereview.chromium.org/2446903008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/custom/CustomElementTest.cpp:250:
EXPECT_NE(nullptr, definition) << "a-a, a-a should be registered";
It would be more precise to hang onto the definition and test equality with it.
Let's make define return a CustomElementDefinition*.

https://codereview.chromium.org/2446903008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/custom/CustomElementTest.cpp:251:
EXPECT_EQ(AtomicString("a-a"), definition->descriptor().name());
Just use EXPECT_EQ(..., definition->descriptor()) etc. it already knows how to
compare both name and local name.

https://codereview.chromium.org/2446903008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/custom/CustomElementTest.cpp:257: //
TODO(yurak): uncomment once the define algorithm is committed
Maybe just omit this instead of adding commented out code. That way we'll get
new functionality, new test which makes for a nice patch.

[yurak, 2016-10-28 04:11:09]

Description was changed from

==========
https://html.spec.whatwg.org/multipage/scripting.html#look-up-a-custom-elemen...

Steps 1-3 already implemented in:
    /core/html/parser/HTMLConstructionSite.cpp

Steps 4-6 completed in CustomElementRegistry.cpp

Unit tests added, some of it depends on patch with custom element define
algorithm.

BUG=648828
==========

to

==========
https://html.spec.whatwg.org/multipage/scripting.html#look-up-a-custom-elemen...

Steps 1-3 already implemented in:
    /core/html/parser/HTMLConstructionSite.cpp

Steps 4-6 made a little faster in CustomElementRegistry.cpp

Unit tests added for custom element definition look up.

BUG=648828
==========

[yurak, 2016-10-31 05:10:54]

Description was changed from

==========
https://html.spec.whatwg.org/multipage/scripting.html#look-up-a-custom-elemen...

Steps 1-3 already implemented in:
    /core/html/parser/HTMLConstructionSite.cpp

Steps 4-6 made a little faster in CustomElementRegistry.cpp

Unit tests added for custom element definition look up.

BUG=648828
==========

to

==========
https://html.spec.whatwg.org/multipage/scripting.html#look-up-a-custom-elemen...

Steps 1-3 already implemented in:
    /core/html/parser/HTMLConstructionSite.cpp

Steps 4-6 made a little faster in CustomElementRegistry.cpp

Unit tests added for custom element definition look up.

Replaced uses of definitionForName with definitionFor.
    CustomElementRegistry.cpp
    CustomElement.cpp
There are other calls to definitionForName, but those are fine according to
spec.

BUG=648828
==========

[yurak, 2016-10-31 05:11:40]

Made suggested changes and replaced some uses of definitionForName to use
definitionFor.

PTL

[yurak, 2016-10-31 05:12:47]

Description was changed from

==========
https://html.spec.whatwg.org/multipage/scripting.html#look-up-a-custom-elemen...

Steps 1-3 already implemented in:
    /core/html/parser/HTMLConstructionSite.cpp

Steps 4-6 made a little faster in CustomElementRegistry.cpp

Unit tests added for custom element definition look up.

Replaced uses of definitionForName with definitionFor.
    CustomElementRegistry.cpp
    CustomElement.cpp
There are other calls to definitionForName, but those are fine according to
spec.

BUG=648828
==========

to

==========
https://html.spec.whatwg.org/multipage/scripting.html#look-up-a-custom-elemen...

Steps 1-3 already implemented in:
    /core/html/parser/HTMLConstructionSite.cpp

Steps 4-6 made a little faster in CustomElementRegistry.cpp

Unit tests added for custom element definition look up.

Replaced uses of definitionForName with definitionFor.
    CustomElementRegistry.cpp
    CustomElement.cpp
There are other calls to definitionForName, but those are fine according to
spec.

I'll do another patch to use the 'is' attribute in definitionFor. Right now it's
using the localName twice.

BUG=648828
==========

[dominicc (has gone to gerrit), 2016-11-07 02:17:03]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2016-11-07 02:17:03]

lgtm

Splendid. I think there are some tests we can simplify to use this returned
definition, but we can do that in follow-up clean-up patches.

[commit-bot: I haz the power, 2016-11-07 02:17:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 02:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 02:19:42]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yurak, 2016-11-07 13:26:59]

The CQ bit was checked by yurak@google.com

[commit-bot: I haz the power, 2016-11-07 13:27:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 13:29:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 13:29:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yurak, 2016-11-08 02:03:13]

The CQ bit was checked by yurak@google.com

[yurak, 2016-11-08 02:03:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2446903008/#ps100001
(title: "Patch")

[commit-bot: I haz the power, 2016-11-08 02:03:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 03:15:06]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-08 03:27:45]

Description was changed from

==========
https://html.spec.whatwg.org/multipage/scripting.html#look-up-a-custom-elemen...

Steps 1-3 already implemented in:
    /core/html/parser/HTMLConstructionSite.cpp

Steps 4-6 made a little faster in CustomElementRegistry.cpp

Unit tests added for custom element definition look up.

Replaced uses of definitionForName with definitionFor.
    CustomElementRegistry.cpp
    CustomElement.cpp
There are other calls to definitionForName, but those are fine according to
spec.

I'll do another patch to use the 'is' attribute in definitionFor. Right now it's
using the localName twice.

BUG=648828
==========

to

==========
https://html.spec.whatwg.org/multipage/scripting.html#look-up-a-custom-elemen...

Steps 1-3 already implemented in:
    /core/html/parser/HTMLConstructionSite.cpp

Steps 4-6 made a little faster in CustomElementRegistry.cpp

Unit tests added for custom element definition look up.

Replaced uses of definitionForName with definitionFor.
    CustomElementRegistry.cpp
    CustomElement.cpp
There are other calls to definitionForName, but those are fine according to
spec.

I'll do another patch to use the 'is' attribute in definitionFor. Right now it's
using the localName twice.

BUG=648828

Committed: https://crrev.com/24d712bfdf73e44b31fa9d058ba37e035cbe58ad
Cr-Commit-Position: refs/heads/master@{#430498}
==========

[commit-bot: I haz the power, 2016-11-08 03:27:48]

Patchset 6 (id:??) landed as
https://crrev.com/24d712bfdf73e44b31fa9d058ba37e035cbe58ad
Cr-Commit-Position: refs/heads/master@{#430498}