Custom Elements: Lookup custom element definition algorithm

third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/custom/CustomElementRegistry.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptCustomElementDefinitionBuilder.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
@@ skipping 176 matching lines @@
 ScriptValue CustomElementRegistry::get(const AtomicString& name) {
   CustomElementDefinition* definition = definitionForName(name);
   if (!definition) {
     // Binding layer converts |ScriptValue()| to script specific value,
     // e.g. |undefined| for v8.
     return ScriptValue();
   }
   return definition->getConstructorForScript();
 }
 
+// https://html.spec.whatwg.org/multipage/scripting.html#look-up-a-custom-element-definition
+// At this point, what the spec calls 'is' is 'name' from desc
 CustomElementDefinition* CustomElementRegistry::definitionFor(
     const CustomElementDescriptor& desc) const {
-  CustomElementDefinition* definition = definitionForName(desc.name());
-  if (!definition)
-    return nullptr;
-  // The definition for a customized built-in element, such as
-  // <button is="my-button"> should not be provided for an
-  // autonomous element, such as <my-button>, even though the
-  // name "my-button" matches.
-  return definition->descriptor() == desc ? definition : nullptr;
+  // 4. If there is a definition in registry with name equal to localName and

[dominicc (has gone to gerrit), 2016/10/27 04:33:14]

Try to write this with only one lookup with definitionForName. Note: localName
== name for autonomous custom elements.

+  // local name equal to localName, return that definition
+  CustomElementDefinition* definition = definitionForName(desc.localName());
+  if (definition and definition->descriptor().localName() == desc.localName())
+    return definition;
+  // 5. If there is a definition in registry with name equal to is and local
+  // name equal to localName, return that definition
+  definition = definitionForName(desc.name());
+  if (definition and definition->descriptor().localName() == desc.localName())
+    return definition;
+  // 6. Return null
+  return nullptr;
 }
 
 bool CustomElementRegistry::nameIsDefined(const AtomicString& name) const {
   return m_definitions.contains(name);
 }
 
 void CustomElementRegistry::entangle(V0CustomElementRegistrationContext* v0) {
   m_v0->add(v0);
   v0->setV1(this);
 }
@@ skipping 61 matching lines @@
   m_upgradeCandidates->remove(it);
 
   Document* document = m_owner->document();
   if (!document)
     return;
 
   sorter.sorted(elements, document);
 }
 
 }  // namespace blink