Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen

ui/views/bubble/bubble_delegate.h

Index: ui/views/bubble/bubble_delegate.h
diff --git a/ui/views/bubble/bubble_delegate.h b/ui/views/bubble/bubble_delegate.h
index 4a0bb30ec0160b49e25167769261f49be2894b10..6ca1b880d747bce46c9b2dff4ceaae26f8500f99 100644
--- a/ui/views/bubble/bubble_delegate.h
+++ b/ui/views/bubble/bubble_delegate.h
@@ -59,10 +59,10 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView,
   bool close_on_deactivate() const { return close_on_deactivate_; }
   void set_close_on_deactivate(bool close) { close_on_deactivate_ = close; }
 
-  View* anchor_view() const { return anchor_view_; }
+  View* GetAnchorView() const;

[sky, 2013/09/30 14:58:45]

This should return const View*. If you need a non-const View*, then make it:
View* GetAnchorView();

[Mr4D (OOO till 08-26), 2013/09/30 16:22:32]

I do not quite follow here. Beside the point that it was before const - the
function still does not change the internal state of this class.

To answer your question: No - the view cannot be const since the view is being
used with non const functions.

I tried to remove the const (even though it left me puzzled why that would be
wise) and it led to a flood of other functions which required it to be const
(which would therefore be non const either). So if you really want to remove the
const - be prepared for a giant review. Still want it?

   Widget* anchor_widget() const { return anchor_widget_; }
 
-  // The anchor rect is used in the absence of an anchor view.
+  // The anchor rect is used in the absence of an assigned anchor view.
   const gfx::Rect& anchor_rect() const { return anchor_rect_; }
 
   BubbleBorder::Arrow arrow() const { return arrow_; }
@@ -141,8 +141,11 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView,
   // Perform view initialization on the contents for bubble sizing.
   virtual void Init();
 
-  // Set the anchor view or rect; set these before CreateBubble or Show.
-  void set_anchor_view(View* anchor_view) { anchor_view_ = anchor_view; }
+  // Set the anchor view or rect; set these before CreateBubble or Show. Note
+  // that if a valid view gets passed, the anchor rect will get ignored. If the
+  // view gets deleted, but no new view gets set, the last known anchor postion
+  // will get returned.
+  void SetAnchorView(View* anchor_view);
   void set_anchor_rect(const gfx::Rect& rect) { anchor_rect_ = rect; }
 
   // Resize and potentially move the bubble to fit the content's preferred size.
@@ -174,8 +177,10 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView,
   bool close_on_esc_;
   bool close_on_deactivate_;
 
-  // The view and widget to which this bubble is anchored.
-  View* anchor_view_;
+  // The view and widget to which this bubble is anchored. Since an anchor view
+  // can be deleted without notice, we store it in the ViewStorage and retrieve
+  // it from there. It will make sure that the view is still valid.
+  int anchor_view_storage_id_;

[sky, 2013/09/30 14:58:45]

const

[Mr4D (OOO till 08-26), 2013/09/30 16:22:32]

Done.

   Widget* anchor_widget_;
 
   // The anchor rect used in the absence of an anchor view.