Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen

ui/views/bubble/bubble_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_
 
 #include "base/gtest_prod_util.h"
 #include "ui/gfx/animation/animation_delegate.h"
 #include "ui/views/bubble/bubble_border.h"
@@ skipping 41 matching lines @@
   virtual void OnWidgetActivationChanged(Widget* widget, bool active) OVERRIDE;
   virtual void OnWidgetBoundsChanged(Widget* widget,
                                      const gfx::Rect& new_bounds) OVERRIDE;
 
   bool close_on_esc() const { return close_on_esc_; }
   void set_close_on_esc(bool close_on_esc) { close_on_esc_ = close_on_esc; }
 
   bool close_on_deactivate() const { return close_on_deactivate_; }
   void set_close_on_deactivate(bool close) { close_on_deactivate_ = close; }
 
-  View* anchor_view() const { return anchor_view_; }
+  View* GetAnchorView() const;

[sky, 2013/09/30 14:58:45]

This should return const View*. If you need a non-const View*, then make it:
View* GetAnchorView();

[Mr4D (OOO till 08-26), 2013/09/30 16:22:32]

I do not quite follow here. Beside the point that it was before const - the
function still does not change the internal state of this class.

To answer your question: No - the view cannot be const since the view is being
used with non const functions.

I tried to remove the const (even though it left me puzzled why that would be
wise) and it led to a flood of other functions which required it to be const
(which would therefore be non const either). So if you really want to remove the
const - be prepared for a giant review. Still want it?

   Widget* anchor_widget() const { return anchor_widget_; }
 
-  // The anchor rect is used in the absence of an anchor view.
+  // The anchor rect is used in the absence of an assigned anchor view.
   const gfx::Rect& anchor_rect() const { return anchor_rect_; }
 
   BubbleBorder::Arrow arrow() const { return arrow_; }
   void set_arrow(BubbleBorder::Arrow arrow) { arrow_ = arrow; }
 
   BubbleBorder::Shadow shadow() const { return shadow_; }
   void set_shadow(BubbleBorder::Shadow shadow) { shadow_ = shadow; }
 
   SkColor color() const { return color_; }
   void set_color(SkColor color) {
@@ skipping 58 matching lines @@
   virtual bool AcceleratorPressed(const ui::Accelerator& accelerator) OVERRIDE;
   virtual void OnNativeThemeChanged(const ui::NativeTheme* theme) OVERRIDE;
 
   // gfx::AnimationDelegate overrides:
   virtual void AnimationEnded(const gfx::Animation* animation) OVERRIDE;
   virtual void AnimationProgressed(const gfx::Animation* animation) OVERRIDE;
 
   // Perform view initialization on the contents for bubble sizing.
   virtual void Init();
 
-  // Set the anchor view or rect; set these before CreateBubble or Show.
-  void set_anchor_view(View* anchor_view) { anchor_view_ = anchor_view; }
+  // Set the anchor view or rect; set these before CreateBubble or Show. Note
+  // that if a valid view gets passed, the anchor rect will get ignored. If the
+  // view gets deleted, but no new view gets set, the last known anchor postion
+  // will get returned.
+  void SetAnchorView(View* anchor_view);
   void set_anchor_rect(const gfx::Rect& rect) { anchor_rect_ = rect; }
 
   // Resize and potentially move the bubble to fit the content's preferred size.
   void SizeToContents();
 
   BubbleFrameView* GetBubbleFrameView() const;
 
  private:
   friend class BubbleBorderDelegate;
 
@@ skipping 11 matching lines @@
   // Handles widget visibility changes.
   void HandleVisibilityChanged(Widget* widget, bool visible);
 
   // Fade animation for bubble.
   scoped_ptr<gfx::SlideAnimation> fade_animation_;
 
   // Flags controlling bubble closure on the escape key and deactivation.
   bool close_on_esc_;
   bool close_on_deactivate_;
 
-  // The view and widget to which this bubble is anchored.
-  View* anchor_view_;
+  // The view and widget to which this bubble is anchored. Since an anchor view
+  // can be deleted without notice, we store it in the ViewStorage and retrieve
+  // it from there. It will make sure that the view is still valid.
+  int anchor_view_storage_id_;

[sky, 2013/09/30 14:58:45]

const

[Mr4D (OOO till 08-26), 2013/09/30 16:22:32]

Done.

   Widget* anchor_widget_;
 
   // The anchor rect used in the absence of an anchor view.
   gfx::Rect anchor_rect_;
 
   // If true, the bubble will re-anchor (and may resize) with |anchor_widget_|.
   bool move_with_anchor_;
 
   // The arrow's location on the bubble.
   BubbleBorder::Arrow arrow_;
@@ skipping 30 matching lines @@
 
   // Parent native window of the bubble.
   gfx::NativeView parent_window_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleDelegateView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_