Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen

ash/shelf/overflow_bubble.cc

Index: ash/shelf/overflow_bubble.cc
diff --git a/ash/shelf/overflow_bubble.cc b/ash/shelf/overflow_bubble.cc
index 84a3b8bdd329492462e85d5911dd6fbaf8e4727a..a94a2d30728d0363eb67715ce984263b1050c8d8 100644
--- a/ash/shelf/overflow_bubble.cc
+++ b/ash/shelf/overflow_bubble.cc
@@ -81,8 +81,9 @@ class OverflowBubbleView : public views::BubbleDelegateView {
   virtual gfx::Rect GetBubbleBounds() OVERRIDE;
 
   ShelfLayoutManager* GetShelfLayoutManagerForLauncher() const {
+    DCHECK(AnchorView());

[msw, 2013/09/27 18:20:31]

nit: Remove this. DCHECKing just before a potential null deref is not necessary.

[Mr4D (OOO till 08-26), 2013/09/27 20:29:35]

Done.

     return ShelfLayoutManager::ForLauncher(
-        anchor_view()->GetWidget()->GetNativeView());
+        AnchorView()->GetWidget()->GetNativeView());
   }
 
   LauncherView* launcher_view_;  // Owned by views hierarchy.
@@ -102,7 +103,7 @@ void OverflowBubbleView::InitOverflowBubble(views::View* anchor,
                                             LauncherView* launcher_view) {
   // set_anchor_view needs to be called before GetShelfLayoutManagerForLauncher
   // can be called.
-  set_anchor_view(anchor);
+  SetAnchorView(anchor);
   set_arrow(GetBubbleArrow());
   set_background(NULL);
   set_color(SkColorSetARGB(kLauncherBackgroundAlpha, 0, 0, 0));