Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen

ash/shelf/overflow_bubble.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/overflow_bubble.h"
 
 #include <algorithm>
 
 #include "ash/launcher/launcher_types.h"
 #include "ash/launcher/launcher_view.h"
@@ skipping 63 matching lines @@
   virtual void ChildPreferredSizeChanged(views::View* child) OVERRIDE;
   virtual bool OnMouseWheel(const ui::MouseWheelEvent& event) OVERRIDE;
 
   // ui::EventHandler overrides:
   virtual void OnScrollEvent(ui::ScrollEvent* event) OVERRIDE;
 
   // views::BubbleDelegate overrides:
   virtual gfx::Rect GetBubbleBounds() OVERRIDE;
 
   ShelfLayoutManager* GetShelfLayoutManagerForLauncher() const {
+    DCHECK(AnchorView());

[msw, 2013/09/27 18:20:31]

nit: Remove this. DCHECKing just before a potential null deref is not necessary.

[Mr4D (OOO till 08-26), 2013/09/27 20:29:35]

Done.

     return ShelfLayoutManager::ForLauncher(
-        anchor_view()->GetWidget()->GetNativeView());
+        AnchorView()->GetWidget()->GetNativeView());
   }
 
   LauncherView* launcher_view_;  // Owned by views hierarchy.
   gfx::Vector2d scroll_offset_;
 
   DISALLOW_COPY_AND_ASSIGN(OverflowBubbleView);
 };
 
 OverflowBubbleView::OverflowBubbleView()
     : launcher_view_(NULL) {
 }
 
 OverflowBubbleView::~OverflowBubbleView() {
 }
 
 void OverflowBubbleView::InitOverflowBubble(views::View* anchor,
                                             LauncherView* launcher_view) {
   // set_anchor_view needs to be called before GetShelfLayoutManagerForLauncher
   // can be called.
-  set_anchor_view(anchor);
+  SetAnchorView(anchor);
   set_arrow(GetBubbleArrow());
   set_background(NULL);
   set_color(SkColorSetARGB(kLauncherBackgroundAlpha, 0, 0, 0));
   set_margins(gfx::Insets(kPadding, kPadding, kPadding, kPadding));
   set_move_with_anchor(true);
   // Overflow bubble should not get focus. If it get focus when it is shown,
   // active state item is changed to running state.
   set_use_focusless(true);
 
   // Makes bubble view has a layer and clip its children layers.
@@ skipping 197 matching lines @@
   DCHECK(widget == bubble_->GetWidget());
   bubble_ = NULL;
   anchor_ = NULL;
   launcher_view_ = NULL;
   ShelfLayoutManager::ForLauncher(
       widget->GetNativeView())->shelf_widget()->launcher()->SchedulePaint();
 }
 
 }  // namespace internal
 }  // namespace ash