Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2446893006: Convert editing/selection/4932260-[123].html to utilize w3c test harness (Closed)

Created:
4 years, 1 month ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/selection/4932260-[123].html to utilize w3c test harness This patch converts "4932260-[123].html" to utilize w3c test harness with |assert_selection()| to simplify test case and consolidate into "move_around_image.html" since these test files were committed in same patch for improving code health. This patch is a preparation of http://crrev.com/1958093002 BUG=625533 TEST=n/a; no behavior chagnes Committed: https://crrev.com/4426277e20a694987c4a324b385d07e79279ff2c Cr-Commit-Position: refs/heads/master@{#428290}

Patch Set 1 : 2016-10-26T16:41:10 #

Total comments: 4

Patch Set 2 : 2016-10-27T14:42:40 #

Patch Set 3 : 2016-10-28T12:57:04 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -201 lines) Patch
D third_party/WebKit/LayoutTests/editing/selection/4932260-1.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/4932260-2.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/4932260-3.html View 1 chunk +0 lines, -12 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/4932260-1-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/4932260-1-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/4932260-2-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/4932260-2-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/4932260-3-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/4932260-3-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/4932260-1-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/4932260-1-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/4932260-2-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/4932260-2-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/4932260-3-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/4932260-3-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/4932260-1-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/4932260-1-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/4932260-2-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/4932260-2-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/4932260-3-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/4932260-3-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 30 (17 generated)
yosin_UTC9
PTAL
4 years, 1 month ago (2016-10-26 08:45:51 UTC) #5
Xiaocheng
https://codereview.chromium.org/2446893006/diff/1/third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html File third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html (right): https://codereview.chromium.org/2446893006/diff/1/third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html#newcode40 third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html:40: selection => selection.modify('move', 'forward', 'sentence'), Should be move forward ...
4 years, 1 month ago (2016-10-26 09:31:04 UTC) #8
yosin_UTC9
https://codereview.chromium.org/2446893006/diff/1/third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html File third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html (right): https://codereview.chromium.org/2446893006/diff/1/third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html#newcode40 third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html:40: selection => selection.modify('move', 'forward', 'sentence'), On 2016/10/26 at 09:31:04, ...
4 years, 1 month ago (2016-10-26 09:40:39 UTC) #9
Xiaocheng
On 2016/10/26 at 09:40:39, yosin wrote: > https://codereview.chromium.org/2446893006/diff/1/third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html > File third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html (right): > > https://codereview.chromium.org/2446893006/diff/1/third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html#newcode40 ...
4 years, 1 month ago (2016-10-26 09:48:23 UTC) #10
yosin_UTC9
PTAL Update to follow review comments.
4 years, 1 month ago (2016-10-27 07:51:22 UTC) #15
Xiaocheng
lgtm
4 years, 1 month ago (2016-10-27 08:01:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446893006/20001
4 years, 1 month ago (2016-10-27 08:01:54 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/323519)
4 years, 1 month ago (2016-10-27 09:23:46 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446893006/20001
4 years, 1 month ago (2016-10-28 02:04:29 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/324299)
4 years, 1 month ago (2016-10-28 03:25:42 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446893006/40001
4 years, 1 month ago (2016-10-28 04:01:24 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-28 05:16:41 UTC) #28
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 05:18:43 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4426277e20a694987c4a324b385d07e79279ff2c
Cr-Commit-Position: refs/heads/master@{#428290}

Powered by Google App Engine
This is Rietveld 408576698