third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html - Issue 2446893006: Convert editing/selection/4932260-[123].html to utilize w3c test harness

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html

Issue 2446893006: Convert editing/selection/4932260-[123].html to utilize w3c test harness (Closed)

Patch Set: 2016-10-26T16:41:10 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/4932260-3.html ('k') | third_party/WebKit/LayoutTests/platform/linux/editing/selection/4932260-1-expected.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <script src="../../assert_selection.js"></script>

	5 <script>

	6 test(() => assert_selection(

	7 [

	8 '<div contenteditable>',

	9 '\|foo <img src="../../resources/abe.png"> bar',

	10 '</div>',

	11 ].join(''),

	12 selection => selection.modify('move', 'forward', 'sentence'),

	13 [

	14 '<div contenteditable>',

	15 'foo <img src="../../resources/abe.png"> bar\|',

	16 '</div>',

	17 ].join('')),

	18 'Move forward sentence');

	19

	20 test(() => assert_selection(

	21 [

	22 '<div contenteditable>',

	23 'foo <img src="../../resources/abe.png"> bar\|',

	24 '</div>',

	25 ].join(''),

	26 selection => selection.modify('move', 'backward', 'sentence'),

	27 [

	28 '<div contenteditable>',

	29 '\|foo <img src="../../resources/abe.png"> bar',

	30 '</div>',

	31 ].join('')),

	32 'Move backward sentence');

	33

	34 test(() => assert_selection(

	35 [

	36 '<div contenteditable>',

	37 '\|foo<img src="../../resources/abe.png">bar',

	38 '</div>',

	39 ].join(''),

	40 selection => selection.modify('move', 'forward', 'sentence'),
	Xiaocheng 2016/10/26 09:31:04 Should be move forward by word twice. Should be move forward by word twice. yosin_UTC9 2016/10/26 09:40:39 No need to move twice to verify 'move-forward-sent Show quoted text On 2016/10/26 at 09:31:04, Xiaocheng wrote: > Should be move forward by word twice. No need to move twice to verify 'move-forward-sentence'. In other words, we should verify minimal unit of action rather than combination.
	41 [

	42 '<div contenteditable>',

	43 'foo<img src="../../resources/abe.png">bar\|',

	44 '</div>',

	45 ].join('')),

	46 'Move forward word');

	47

	48 test(() => assert_selection(

	49 [

	50 '<div contenteditable>',

	51 'foo<img src="../../resources/abe.png">bar\|',

	52 '</div>',

	53 ].join(''),

	54 selection => selection.modify('move', 'backward', 'sentence'),
	Xiaocheng 2016/10/26 09:31:04 Should be move backward by word twice. Should be move backward by word twice. yosin_UTC9 2016/10/26 09:40:38 No need to move twice to verify 'move-backward-sen Show quoted text On 2016/10/26 at 09:31:04, Xiaocheng wrote: > Should be move backward by word twice. No need to move twice to verify 'move-backward-sentence'.
	55 [

	56 '<div contenteditable>',

	57 '\|foo<img src="../../resources/abe.png">bar',

	58 '</div>',

	59 ].join('')),

	60 'Move backward word');

	61 </script>

OLD	NEW